139655 – net-nntp/pan-0.14.2 (current stable) does not build with gcc4

Bug 139655 - net-nntp/pan-0.14.2 (current stable) does not build with gcc4

Summary: net-nntp/pan-0.14.2 (current stable) does not build with gcc4

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Net-news project

URL:
Whiteboard:
Keywords:

Duplicates (1):	139656 (view as bug list)
Depends on:
Blocks:

Reported:	2006-07-08 05:18 UTC by Andrew Gaffney (RETIRED)
Modified:	2006-09-03 13:20 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrew Gaffney (RETIRED) gentoo-dev

2006-07-08 05:18:30 UTC

The error is:

msort.c: In function 'msort_with_tmp':
msort.c:68: error: invalid lvalue in increment
msort.c:69: error: invalid lvalue in increment
msort.c:74: error: invalid lvalue in increment
msort.c:75: error: invalid lvalue in increment

It builds fine with gcc-3.4.6, and 0.14.2.91-r3 builds just fine with gcc4. Any chance to get this version stable?

Comment 1 Jakub Moc (RETIRED) gentoo-dev

2006-07-08 05:25:59 UTC

*** Bug 139656 has been marked as a duplicate of this bug. ***

Comment 2 Sven Wegener gentoo-dev

2006-08-09 11:45:47 UTC

Nope, upstream considers it beta software and inappropriate to be marked stable. I ported the gcc-4 patch to 0.14.2, which should be enough.

Comment 3 Jack Browning 2006-09-02 09:12:05 UTC

(In reply to comment #2)
> Nope, upstream considers it beta software and inappropriate to be marked
> stable. I ported the gcc-4 patch to 0.14.2, which should be enough.

I've tried to build both the 0.14.2 and 0.14.2-r1 packages under the new gcc4/glibc toolchain, and they both failed in exactly the same manner as the original reporter described. In both cases, I saw no mention of the gcc4 patch being applied prior to the start of compilation.

Has this patch been included in 0.14.2 package?

Comment 4 Jack Browning 2006-09-02 10:02:47 UTC

I moved the net-nntp/pan dir out of my portage tree and resynced to see if I somehow missed the 0.14.2 gcc4 patch being pushed out. After syncing, I checked the 0.14.2 ebuild and saw the gcc4 patch referenced in src_unpack(). When I built the 0.14.2 package, though, I noticed the gcc4 patch was not being applied because of this:

>>> Emerging (1 of 1) net-nntp/pan-0.14.2 to /
>>> checking ebuild checksums ;-)
>>> checking auxfile checksums ;-)
>>> checking miscfile checksums ;-)
>>> checking pan-0.14.2.tar.bz2 ;-)
>>> Unpacking source...
>>> Unpacking pan-0.14.2.tar.bz2 to /more/portage-build/portage/pan-0.14.2/work
/more/portage/net-nntp/pan/pan-0.14.2.ebuild: line 40: epatch: command not found

The build, of course, failed.

Comparing the 0.14.2 ebuild to other ebuilds that use the gcc4 patch, I noticed that the 0.14.2 ebuild only inherits libtool, while the others inherit both libtool *and* eutils. The 0.14.2 ebuild, it appears, needs to inherit eutils for the patch to be applied.

Comment 5 Chris Gianelloni (RETIRED) gentoo-dev

2006-09-03 13:20:55 UTC

I added eutils to inherit, since we're shipping pan on the LiveCD media and I don't want anything we're shipping to be broken.

Thanks...