Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 139554 - aterm-1.0.0 borderless option doesn't work
Summary: aterm-1.0.0 borderless option doesn't work
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: Normal normal (vote)
Assignee: Gentoo Afterstep Maintainers (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-07 07:41 UTC by buzz22
Modified: 2007-09-22 14:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
A patch to correct the problem (aterm-1.0.0-borderless.patch,492 bytes, patch)
2006-07-07 07:50 UTC, buzz22
Details | Diff
change _MOTIF_WM_INFO to _MOTIF_WM_HINTS (aterm-borderless.diff,559 bytes, patch)
2007-07-19 03:26 UTC, Mark Tiefenbruck
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description buzz22 2006-07-07 07:41:20 UTC
The -bl (--borderLess) option of aterm doesn't work anymore in the version 1.0.0-r1. I'm using the Xfce Desktop Environment but test it in KDE too, and the result is the same.

Reproducible: Always
Steps to Reproduce:
1. emerge x11-terms/aterm
2. aterm -bl

Actual Results:
The border of the term's window is still present.

Expected Results:
A term's window without border.
Comment 1 buzz22 2006-07-07 07:50:00 UTC
Created attachment 91137 [details, diff]
A patch to correct the problem

From aterm's ChangeLog :

2005-01-19
* applyed gentoo patches for borderless aterm using motif hints and
  internal border width  - cmdline options -bl and -ib

but the author forgot one of the instruction, that's why it doesn't work in v1.0.0
Comment 2 Mark Tiefenbruck 2007-07-19 03:26:37 UTC
Created attachment 125303 [details, diff]
change _MOTIF_WM_INFO to _MOTIF_WM_HINTS

Strange choice. Why not just use the correct Atom in the first place, as in this patch?
Comment 3 Mark Tiefenbruck 2007-07-19 03:30:26 UTC
By the way, it seems that the borderLess option has been removed from aterm cvs. If this option is important to you, then you might want to pester the AfterStep team or switch terminals.
Comment 4 Andrew Hurst 2007-07-20 00:04:08 UTC
Afterstep people seem to be putting aterm out to pasture.
Too much work to make it utf-able apparently.

Can we add the _MOTIF_WM_HINTS patch and call it aterm-1.0.0-r2?

Likely this nice little terminal will go the way of XMMS soon!
Comment 5 Andrew Hurst 2007-07-20 00:33:22 UTC
ok, they've agreed, after much pestering, to accept a patch against current cvs to put the -borderLess/-bl option back in.

I'll see what I can come up with.

Andy
Comment 6 Nathan Mahon 2007-07-20 15:18:02 UTC
(In reply to comment #5)
> ok, they've agreed, after much pestering, to accept a patch against current cvs
> to put the -borderLess/-bl option back in.
> 
> I'll see what I can come up with.
> 
> Andy
> 

MUCH PESTERING?!

Technically, I said I'd /look/ at a patch. :)
but I do plan on fixing this. :)
Comment 7 Andrew Hurst 2007-07-20 22:33:44 UTC
Ok, then a very minor amount of pestering,
perhaps even negligible pestering.

mark your patch works fine against current cvs.

I'm very grateful,

Andy

Comment 8 Nathan Mahon 2007-08-01 14:06:40 UTC
(In reply to comment #7)
> Ok, then a very minor amount of pestering,
> perhaps even negligible pestering.
> 
> mark your patch works fine against current cvs.
> 
> I'm very grateful,
> 
> Andy
> 

And now, after MUCH PESTERING, it's in cvs and we are now testing.
Feel free to assist.  I used Mark's patch.
Comment 9 Nathan Mahon 2007-08-01 20:48:57 UTC
someone please verify this works fine in 1.0.1, released today?
Comment 10 Andrew Hurst 2007-08-01 23:59:27 UTC
-borderLess option now works fine in 1.0.1.

I didn't pester <i>that</i> much..

Thanks Nathan =)
Comment 11 Andrew Hurst 2007-08-09 21:55:38 UTC
This bug can be closed. [is resolved fixed]