Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 139377 - New ebuild for nicotine+-1.2.2
Summary: New ebuild for nicotine+-1.2.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Jon Hood (RETIRED)
URL: http://www.nicotine-plus.org/
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2006-07-05 16:30 UTC by Josu López Fernández
Modified: 2006-07-07 19:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
nicotine+-1.2.2.ebuild (nicotine+-1.2.2.ebuild,1.02 KB, text/plain)
2006-07-05 16:30 UTC, Josu López Fernández
Details
nicotine+-fPIC.patch (nicotine+-fPIC.patch,467 bytes, patch)
2006-07-05 16:31 UTC, Josu López Fernández
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josu López Fernández 2006-07-05 16:30:10 UTC
Hi!
nicotine+ is a fork of nicotine, a rewrite of pyslsk, so it is a client for the soulseek p2p network. Nicotine isn't mantained, and nicotine+ has some fixes and new features.

I upload the ebuild, but it is going to be added to the sunrise overlay.

Good bye!
Comment 1 Josu López Fernández 2006-07-05 16:30:55 UTC
Created attachment 91013 [details]
nicotine+-1.2.2.ebuild
Comment 2 Josu López Fernández 2006-07-05 16:31:46 UTC
Created attachment 91014 [details, diff]
nicotine+-fPIC.patch
Comment 3 Josu López Fernández 2006-07-06 07:41:02 UTC
Here is it in sunrise overlay:
http://gentoo-sunrise.org/svn/reviewed/net-p2p/nicotine+

Good bye
Comment 4 Jon Hood (RETIRED) gentoo-dev 2006-07-06 17:37:32 UTC
2 things:
1) why is -fPIC needed on all cflags? It's not a good thing to use fPIC on binaries that are going to be run, only libraries.
2) 1.2.3 tries to install into /usr/lib on 64-bit systems. It needs to install into /usr/$(get_libdir) (see multilib.eclass).
Comment 5 Josu López Fernández 2006-07-06 17:49:08 UTC
Hello!
The patch only affects the compilation of the trayicon, which is a library (trayicon.so). Yesterday when I did the ebuild, the version 1.2.3 isn't yet released, but now I'm seeing that the patch isn't needed more, because upstream has added -fPIC to the CFLAGS.

The other problem I have to see tomorrow, because today it's too late and I have to read again both eclasses (multilib.eclass and distutils.eclass)

Good bye and thanks for your interest in that great application!
Comment 6 Josu López Fernández 2006-07-07 09:41:12 UTC
I have uploaded new version with the changes you mentioned:
http://gentoo-sunrise.org/svn/reviewed/net-p2p/nicotine+/nicotine+-1.2.3.ebuild
On my amd64 all is installed into /usr/lib64.

Good bye
Comment 7 Jon Hood (RETIRED) gentoo-dev 2006-07-07 19:47:50 UTC
1.2.3 now in portage; thanks!