Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 138894 - cdparanoia SG_IO patch on kernel 2.6.15 does not work with true SCSI drives
Summary: cdparanoia SG_IO patch on kernel 2.6.15 does not work with true SCSI drives
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-02 11:44 UTC by Daniel Glöckner
Modified: 2006-10-21 16:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cdparanoia_vs_Plextor_PX-40TS.txt (cdparanoia_vs_Plextor_PX-40TS.txt,2.58 KB, text/plain)
2006-07-27 06:57 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details
cdparanoia_vs_Plextor_PX-W124S.txt (cdparanoia_vs_Plextor_PX-W124S.txt,6.08 KB, text/plain)
2006-07-27 07:03 UTC, Lars Wendler (Polynomial-C) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Glöckner 2006-07-02 11:44:38 UTC
With the SG_IO patch applied, cdparanoia does the SG_EMULATED_HOST ioctl on /dev/srX instead of /dev/sgX.
That ioctl is executed in linux >=2.6.15 in block/scsi_ioctl.c's sg_emulated_host() (instead of sg.c's sg_ioctl()).
The comment above that function tells us that the author knew no reason to differentiate between SCSI and emulated-SCSI and thus always returns emulated-SCSI.

This makes cdparanoia choose a wrong command set for my SCSI Plextor PX-40TS.

So either sg_emulated_host() needs to be fixed or cdparanoia must work around it.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2006-07-27 06:57:16 UTC
Created attachment 92850 [details]
cdparanoia_vs_Plextor_PX-40TS.txt

Hi,

I second this. I have a PLEXTOR PX-40TS and a PLEXTOR PX-W124S and cdparanoia-3.9.8-r4 (which introduced the SG_IO patches) doesn't work with both drives. I attached the output of cdparanoia so you can see the errormessages I can see when I try to rip an audio-CD.
cdparanoia-3.9.8-r3 works flawlessly.

Cheers
Poly-C
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2006-07-27 07:03:17 UTC
Created attachment 92851 [details]
cdparanoia_vs_Plextor_PX-W124S.txt
Comment 3 Sander Sweers 2006-08-05 13:34:07 UTC
http://forums.gentoo.org/viewtopic.php?p=3494216#3494216

Another case in the above thread, this time an old TEAC CD-R55S 1.0R. Maybe for the time being put the patches under a use flag?
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2006-10-05 17:15:30 UTC
Hi,

could you please test if cdparanoia works when you use the generic scsi-device /dev/sg? instead of /dev/sr? (or any /dev/cdr{om,w} symlink pointing to /dev/sr?)?
It seems as I have to use /dev/sg3 for my PLEXTOR PX-40TS to get cdparanoia ripping audio-CDs

Cheers
Poly-C
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-10-21 16:14:35 UTC
I've removed the SG_IO patches from 3.9.8-r5, they caused more pain than good. I'll try to bump to the latest version as soon as I can, and see to merge the current patches.

New rule about cdparanoia: don't apply redhat patches.