Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 138887 - dev-java/kaffe little cleanup
Summary: dev-java/kaffe little cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-07-02 10:22 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-07-03 10:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild patch (kaffe-ebuild-cleanup.patch,1.13 KB, patch)
2006-07-02 10:23 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-07-02 10:22:40 UTC
So here it is a little cleanup for the current kaffe ebuild. Basically it just uses econf instead of ./configure (to make use of confcache and gnuconfig update), emake instead of make (if there are parallel make issues, just force -j1, but don't use "make" as it might be misunderstood, and fixes a bit of quoting. It also replaces strip-flags with filter-flags, that is likely to be what it was intended, and appends -fno-strict-aliasing, as there are rules breakages in the code (upstream is going to force -fno-strict-aliasing for next versions anyway, it seems).

HTH,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2006-07-02 10:23:34 UTC
Created attachment 90707 [details, diff]
Ebuild patch
Comment 2 Josh Nichols (RETIRED) gentoo-dev 2006-07-03 09:54:45 UTC
Changes applied, thanks for the suggestions.
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2006-07-03 10:23:23 UTC
(In reply to comment #2)
> Changes applied, thanks for the suggestions.
> 

Was a bit buggy. Fixed now.
-       local javadoc"=${D}/opt/${P}/bin/javadoc"
+       local javadoc="${D}/opt/${P}/bin/javadoc"

Comment 4 Petteri Räty (RETIRED) gentoo-dev 2006-07-03 10:24:07 UTC
I also think you don't need to quote when assigning. At least I remember reading something like that on the mailing lists.