Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 13868 - /sbin/functions.sh tweaks
Summary: /sbin/functions.sh tweaks
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: Lowest enhancement (vote)
Assignee: Martin Schlemmer (RETIRED)
URL:
Whiteboard:
Keywords:
: 8467 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-01-13 15:23 UTC by SpanKY
Modified: 2003-01-19 17:16 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
/sbin/functions.sh diff (patch,7.65 KB, patch)
2003-01-13 15:24 UTC, SpanKY
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2003-01-13 15:23:18 UTC
- added a #!/bin/sh to the beginning of the file 
- added an additional check to the PATH check at the beginning 
- added NOCOLOR support (Bug 8467) 
- extracted the color used for the [ ] in eend and put into a variable 
    - i like to use it for borders 
    - needed to support NOCOLOR, plus cleaner this way imo 
- added comments to all the display functions 
- removed excess spaces on a few lines
Comment 1 SpanKY gentoo-dev 2003-01-13 15:24:26 UTC
Created attachment 7270 [details, diff]
/sbin/functions.sh diff
Comment 2 SpanKY gentoo-dev 2003-01-13 15:29:49 UTC
*** Bug 8467 has been marked as a duplicate of this bug. ***
Comment 3 Martin Schlemmer (RETIRED) gentoo-dev 2003-01-14 00:27:02 UTC
Mostly good stuff.  I personally do not like the 'let', and most other things
use $(()), so for consistancy (and personal .. :P), I am going to rip that.

Will get to it in the next day or so, thanks!
Comment 4 SpanKY gentoo-dev 2003-01-14 01:06:31 UTC
yeah i was unsure how you'd take the let ... 
i guess let vs $(()) is mostly personal style :) 
Comment 5 Martin Schlemmer (RETIRED) gentoo-dev 2003-01-19 17:16:10 UTC
Ok, merged local, will be on CVS in a bit.