Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 138550 - linux-info get_version does not return the correct version - leads to modules being installed in the wrong place!
Summary: linux-info get_version does not return the correct version - leads to modules...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Highest blocker
Assignee: Gentoo Kernel Miscellaneous
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-29 22:29 UTC by Robin Johnson
Modified: 2010-01-10 08:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kernel-2.eclass.diff (kernel2.eclass.diff,537 bytes, patch)
2006-10-20 07:43 UTC, Christian Heim (RETIRED)
Details | Diff
linux-info.eclass.diff (linux-info.eclass.diff,1.25 KB, patch)
2006-10-20 07:43 UTC, Christian Heim (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-06-29 22:29:05 UTC
the get_version function in linux-info.eclass is not returning the correct kernel version information.
I'm running a git kernel, from Linus's repo.

KV_FULL only gets '2.6.17'
but the output from 'make kernelrelease' is 2.6.17-ge407112e-dirty

This causes linux-mod to install modules to the wrong location!

get_version should change to using the output of 'make kernelrelease' or the include/config/kernel.release file that gets generated.
Comment 1 Daniel Drake (RETIRED) gentoo-dev 2006-06-30 02:14:35 UTC
make kernelrelease is relatively new, if we do use it we must keep the existing code as a fallback.

Also this is a dup but I can't find the original bug
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-06-30 02:26:02 UTC
(In reply to comment #1)
> Also this is a dup but I can't find the original bug

Bug 126013?
Comment 3 Daniel Drake (RETIRED) gentoo-dev 2006-08-20 07:57:15 UTC
not that one
Comment 4 Christian Heim (RETIRED) gentoo-dev 2006-10-20 07:43:05 UTC
Here are some modifications to linux-info and kernel-2 to support the make kernelrelease thing. I still need to dig when exactly the make kernelrelease was introduced (for the check in kernel-2).
Comment 5 Christian Heim (RETIRED) gentoo-dev 2006-10-20 07:43:39 UTC
Created attachment 100089 [details, diff]
kernel-2.eclass.diff
Comment 6 Christian Heim (RETIRED) gentoo-dev 2006-10-20 07:43:53 UTC
Created attachment 100090 [details, diff]
linux-info.eclass.diff
Comment 7 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2007-03-14 01:59:48 UTC
phreak: the file has moved to include/config/kernel.release, please update code to check both locations?
Comment 8 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2010-01-10 08:50:31 UTC
This seems obsolete, and it never looks like it worked anyway.
Using cut for the EXTRAVERSION argument is not reliable with EXTRAVERSION like '-rc5', because the seperator is - not .