Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 138347 - Fix to make busybox build on m68k
Summary: Fix to make busybox build on m68k
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: Other Linux
: High normal (vote)
Assignee: Embedded Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-28 05:51 UTC by Kolbjørn Barmen
Modified: 2006-06-29 19:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kolbjørn Barmen 2006-06-28 05:51:14 UTC
busybox will not build on m68k due to no define for __m68k__ in util-linux/fdisk.c

Easy solution is to just add a "|| define (__m68k__)" to the list:

--- busybox-1.1.3/util-linux/fdisk.c.orig       2006-06-28 14:27:13.000000000 +0200
+++ busybox-1.1.3/util-linux/fdisk.c    2006-06-28 14:29:52.000000000 +0200
@@ -489 +489 @@
-#if defined (i386) || defined (__sparc__) || defined (__arm__) || defined (__mips__) || defined (__s390__) || defined (__sh__) || defined(__x86_64__)
+#if defined (i386) || defined (__sparc__) || defined (__arm__) || defined (__mips__) || defined (__s390__) || defined (__sh__) || defined(__x86_64__) || defined (__m68k__)

No idea whether it is "correct" or not. I have tried using fdisk on various PC disk images on my m68k machines, and it appears to work ok.
Comment 1 SpanKY gentoo-dev 2006-06-28 18:28:22 UTC
the original util-linux fdisk says it does not support m68k and since busybox is based on that, i doubt this one will work either ... working on disk images is one thing, actually working on the hardware used at runtime is another ;)
Comment 2 Kolbjørn Barmen 2006-06-28 19:07:24 UTC
(In reply to comment #1)
> the original util-linux fdisk says it does not support m68k and since busybox
> is based on that, i doubt this one will work either ... working on disk images
> is one thing, actually working on the hardware used at runtime is another ;)

Yeah, but anyone who'd run "regular" PC fdisk on m68k would know that already - it's not fdisk that doesnt support m68k, it's the m68k platforms that never used the (much too limited) PC style partition table.

Or I could prove that it actually works on real hardware? :)

The alternative ofcourse, is to disable fdisk alltogether for m68k, but that requires some fiddling with the .config.
Comment 3 SpanKY gentoo-dev 2006-06-29 19:54:09 UTC
ok, ive committed this upstream ... it'll be in the next busybox release (tomorrow)