Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 137886 - <=app-emulation/xen-tools-3.0.2-r2 doesn't get_domname reliably enough
Summary: <=app-emulation/xen-tools-3.0.2-r2 doesn't get_domname reliably enough
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Andrew Ross (RETIRED)
URL:
Whiteboard:
Keywords: Bug
Depends on:
Blocks:
 
Reported: 2006-06-24 15:15 UTC by Mike Williams
Modified: 2007-03-04 08:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Williams 2006-06-24 15:15:36 UTC
Reliably probably isn't the right word.
Many of the docs I've read put semi-colons at the end of each line in the vm config, so that's what I've done on my test system.
get_domname() doesn't strip that semi-colon off, so making the is_running() check fail whether the vm is actually running or not.
Changing the sed call to:
sed -ne 's/^[ \t]*name[ \t]*=[ \t]*"\([^"]*\)"[;]*/\1/p' $1
(adding a [;] after the last " and before the last *)
makes it work either way of defining config variables.
Comment 1 Andrew Ross (RETIRED) gentoo-dev 2006-08-13 00:35:41 UTC
Thanks for your report and proposed fix.

get_domname() has been rewritten for xen-tools-3.0.2-r3 , which should hit the tree in the next few days (at which point this bug will be resolved).
Comment 2 Andrew Ross (RETIRED) gentoo-dev 2006-08-14 00:20:05 UTC
Fixed xen-tools-3.0.2-r3.
Comment 3 Mike Williams 2006-12-15 04:06:27 UTC
Andrew, while your re-write fixed the problem this bug was originally about, you've unfortunately introduced a new one.
[[:alpha:]_] should be [[:alnum:]_], or you could use \w.
Numbers are legal in VM names.
Comment 4 Andrew Ross (RETIRED) gentoo-dev 2006-12-15 20:31:53 UTC
Mike, according to bug #148628 the alpha->alnum fix was included in -r4

Please check to make sure you're using xen-tools-3.0.2-r4, and let me know so I can properly close this bug.
Comment 5 Mike Williams 2006-12-16 03:38:56 UTC
(In reply to comment #4)
> Mike, according to bug #148628 the alpha->alnum fix was included in -r4
> 
> Please check to make sure you're using xen-tools-3.0.2-r4, and let me know so I
> can properly close this bug.

Ahh, yes, sorry. I'm testing 3.0.3, and as it fails to install the init scripts I took the first one I saw in ${FILESDIR} which is different than ${FILESDIR}/3.0.2-r4.
Comment 6 Andrew Ross (RETIRED) gentoo-dev 2007-03-04 08:06:30 UTC
Reopening so I can mark as fixed - stupid bugzilla :-)
Comment 7 Andrew Ross (RETIRED) gentoo-dev 2007-03-04 08:07:12 UTC
Fixed in xen-tools-3.0.2-r4.