137783 – gentoolkit.Package raises a string instead of an Exception

Bug 137783 - gentoolkit.Package raises a string instead of an Exception

Summary: gentoolkit.Package raises a string instead of an Exception

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Tools (show other bugs)
Hardware:	All Linux

Importance:	High enhancement
Assignee:	Portage Tools Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-06-23 15:31 UTC by René 'Necoro' Neumann
Modified:	2007-01-11 05:06 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch now raising an exception (see above) (gentoolkit-raise.patch,701 bytes, patch) 2006-06-23 15:32 UTC, René 'Necoro' Neumann	Details \| Diff
patch raising an exception (now in unified diff) (gentoolkit_raise.patch,434 bytes, patch) 2006-07-24 16:20 UTC, René 'Necoro' Neumann	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description René 'Necoro' Neumann 2006-06-23 15:31:19 UTC

The gentoolkit.Package-method "get_dependants" (package.py:61) raises a string instead of an Exception. 

This is deprecated behavior and is hard to catch.

I append a patch which just raises a "NotImplementedError" here now.

Comment 1 René 'Necoro' Neumann 2006-06-23 15:32:42 UTC

Created attachment 89957 [details, diff]
patch now raising an exception (see above)

Comment 2 René 'Necoro' Neumann 2006-07-24 16:20:28 UTC

Created attachment 92661 [details, diff]
patch raising an exception (now in unified diff)

Added the patch again, but now in unified diff (realized much to late, that it's been wrong the last time)

Comment 3 Paul Varner (RETIRED) gentoo-dev

2007-01-11 05:06:16 UTC

Fixed in subversion revision 337 and will be released with gentoolkit-0.2.3_pre4. Thanks for the patch!