Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 137076 - sys-apps/shadow Unchecked set*uid() calls (Vendor-Sec)
Summary: sys-apps/shadow Unchecked set*uid() calls (Vendor-Sec)
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Security
URL:
Whiteboard: CONFIDENTIAL no release date set
Keywords:
: 144868 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-17 06:23 UTC by Sune Kloppenborg Jeppesen (RETIRED)
Modified: 2006-08-23 11:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sune Kloppenborg Jeppesen (RETIRED) gentoo-dev 2006-06-17 06:23:37 UTC
Hey, 
 
So I just looked at 4.0.3 (I have no idea if that is the latest version, I got it from the slackware site, for slack 10.2) and here is the vulnerable code: 
 
 if (argc > 1 && argv[1][0] == '-' && strchr ("gfs", argv[1][1])) {
  char buf[200];
 
  setuid (getuid ());
  switch (argv[1][1]) {
  case 'g':
   argv[1] = GPASSWD_PROGRAM; /* XXX warning: const */
   break;
  case 'f':
   argv[1] = CHFN_PROGRAM; /* XXX warning: const */
   break;
  case 's':
   argv[1] = CHSH_PROGRAM; /* XXX warning: const */
   break;
  default:
   usage (E_BAD_ARG);
  }
  snprintf (buf, sizeof buf, _("%s: Cannot execute %s"),
     Prog, argv[1]);
  execvp (argv[1], &argv[1]);
  perror (buf);
  SYSLOG ((LOG_ERR, "cannot execute %s", argv[1]));
  closelog ();
  exit (E_FAILURE);
 }
 
it is located inside main() ! 
 
 
Regards, 
Ilja van Sprundel.
Comment 1 Sune Kloppenborg Jeppesen (RETIRED) gentoo-dev 2006-06-17 06:24:53 UTC
Vapier please advise.
Comment 2 SpanKY gentoo-dev 2006-06-17 12:43:09 UTC
the code in question was removed in shadow-4.0.14

ChangeLog:
2005-10-12  Tomasz K
Comment 3 SpanKY gentoo-dev 2006-06-17 12:43:09 UTC
the code in question was removed in shadow-4.0.14

ChangeLog:
2005-10-12  Tomasz K³oczko  <kloczek@pld.org.pl>
    * src/passwd.c, NEWS, man/passwd.1, man/passwd.1.xml:
    remove handle -f, -g and -s options in passwd.

NEWS:
shadow-4.0.13 -> shadow-4.0.14                      03-01-2006
*** general:
- passwd: remove handle -f, -g and -s options.
Comment 4 Thierry Carrez (RETIRED) gentoo-dev 2006-08-23 11:59:10 UTC
*** Bug 144868 has been marked as a duplicate of this bug. ***