Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 137028 - changelog in package-version pages overlap package image
Summary: changelog in package-version pages overlap package image
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: [OLD] gpackages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Albert Hopkins (RETIRED)
URL: http://packages.gentoo.org
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-16 15:02 UTC by Vlastimil Babka (Caster) (RETIRED)
Modified: 2006-09-30 13:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-06-16 15:02:37 UTC
For example http://packages.gentoo.org/ebuilds/?gentoo-sources-2.6.16-r10 (but all such pages).

When changelog is too wide (or browser window too thin) it overlaps the package "box" picture, making it unreadable. I found this in RSS reader Akregator (uses Konqueror for rendering, where it also happens). In Firefox this doesn't happen, but in Opera it does, so it's 2:1 chance it's bug of the page, not browser :)

The code goes like:
<td valign="top" class="item">
 <p>
   <b>Description:</b>
   <img align="right" src="http://packages.gentoo.org/images/sys-kernel/gentoo-sources.jpg" alt="" class="pkgimg"/>
 </p>
 <p>
   <b>Changes:</b>
   <br/>
...

I'm not HTML expert but I think this meens the image is aligned right only inside the paragraph, with respect to the <b>Description:</b> which is on the same level. But Changelog is in different paragraph.
Also, the page doesn't validate with http://validator.w3.org
Comment 1 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-09-25 04:47:16 UTC
OK I found the cause and very simple and easy fix:

-       <tr><td class="item" valign="top"><p><b>Description:</b> The Portage Package Management System. The primary package management and distribution system for Gentoo. <img class="pkgimg" alt="" src="Gentoo%20Linux%20--%20The%20Fresh%20Ebuilds_files/portage.jpg" align="right"></p><p><b>Changes:</b><br><span style="white-space: pre;">*portage-2.1.2_pre1-r2 (25 Sep 2006)
+       <tr><td class="item" valign="top"><p><b>Description:</b> The Portage Package Management System. The primary package management and distribution system for Gentoo. <img class="pkgimg" alt="" src="Gentoo%20Linux%20--%20The%20Fresh%20Ebuilds_files/portage.jpg" align="right"></p><p><b>Changes:</b><br><span style="white-space: pre-wrap;">*portage-2.1.2_pre1-r2 (25 Sep 2006)

The difference is changing style "white-space: pre;" to "white-space: pre-wrap;"
This ensures wrapping is done also when needed by the browser (i.e. to wrap around the image), not just when the text itself contains a newline. Tested and works in firefox, opera and konqueror. Please consider applying it, it's really annoying bug, thanks.
Comment 2 Albert Hopkins (RETIRED) gentoo-dev 2006-09-30 11:20:41 UTC
I could not repeat the error, but I did implemented the suggested change.  Thanks for reporting this.
Comment 3 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2006-09-30 13:59:50 UTC
Thanks, really fixed the issue in Akregator :)