Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 136972 - mplayer-1.0_pre8 by default with DVB-T UK-Settings
Summary: mplayer-1.0_pre8 by default with DVB-T UK-Settings
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-16 03:37 UTC by Mark Dominik Bürkle
Modified: 2006-07-07 03:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Dominik Bürkle 2006-06-16 03:37:13 UTC
compilation of mplayer-1.0_pre8 warns (#warning) about the DVB-T COUNTRY being set to the default, UK.

I don't even know if the differences between e.g. dvb-t/uk and dvb-t/de might produce any problems and I might have missed the option for DVBT_COUNTRY, too. If there is any: sorry. :-)

But if problems might arise, then I'd prefer to have "the choice"(tm:) and the default should IMHO be based upon Locale settings... else it might break the mplayer-vdr-plugin, among others...

Thanks for reading this. :-)


>>> Emerging (1 of 1) media-video/mplayer-1.0_pre8 to /
...
 * Make
./version.sh `cc -dumpversion`
iconv -f `cat help/help_mp-de.h.charset` -t UTF-8 "help/help_mp-de.h" >> help_mp.h
Adding untranslated messages to help_mp.h
cc -c -I../libvo -I../../libvo -I/usr/X11R6/include -fno-PIC -O4 -D__STDC_LIMIT_MACROS -march=pentium3 -mtune=pentium3 -pipe -ffast-math -fomit-frame-pointer -D_REENTRANT -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE  -I.   -I/usr/include   -I/usr/include/freetype2  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/X11R6/include   -I./libavutil -I./libavcodec   -o mplayer.o mplayer.c
In file included from libmpdemux/dvbin.h:11,
                 from mplayer.c:117:
libmpdemux/dvb_defaults.h:73:3: warning: #warning No DVB-T country defined in dvb_defaults.h, defaulting to UK. Ignore this if using Satellite or Cable.



BTW: all mplayer-builds except this one have "-x86" among others - is that a Typo (~x86) or on purpose? I had mplayer-1.0.20060415 installed and running on ~x86 until yesterday, broke it by recompiling libx264...
(eix mplayer)
     Available versions:  1.0_pre7-r1 1.0_pre8 -1.0.20060102 -1.0.20060217 -1.0.20060302 -1.0.20060408 -1.0.20060415
     Installed:           1.0_pre8
(grep ^KEYWORDS= mplayer-1.0*.ebuild)
...
mplayer-1.0.20060415.ebuild:KEYWORDS="alpha amd64 hppa ~ia64 -ppc -ppc64 sparc -x86"
mplayer-1.0_pre7-r1.ebuild:KEYWORDS="alpha amd64 hppa ia64 ppc ppc64 sparc x86"
mplayer-1.0_pre8.ebuild:KEYWORDS="~alpha ~amd64 ~hppa ~ia64 ppc ppc64 ~sparc x86"
Comment 1 Mark Dominik Bürkle 2006-06-16 03:43:46 UTC
the #warning is the same for ~x86 in 20060415.ebuild.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2006-06-16 03:49:21 UTC
(In reply to comment #0)
> BTW: all mplayer-builds except this one have "-x86" among others - is that a
> Typo (~x86) or on purpose? 

No, it's not a typo, it's the only way to force the "downgrade" because of the broken versioning scheme.
Comment 3 Matthias Schwarzott gentoo-dev 2006-07-05 14:59:08 UTC
I think that function is not so important, as it only sets some default-values for dvb-t transmission, but these parameters do exist in every entry in the channels-file.

Have to dig into the code to see if this is useful at all.
Comment 4 Matthias Schwarzott gentoo-dev 2006-07-07 02:28:00 UTC
I checked the source-code: The parameters set according to the country-choose are never used. They can be removed (or at least the compiler-warning).

I requested to remove them completely from mplayer-source-code on the mplayer-dev-ML.
Comment 5 Luca Barbato gentoo-dev 2006-07-07 03:10:34 UTC
upstream issue, will be fixed there