Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 136819 - sys-fs/avfs-0.9.7 version bump (no more cvs :))
Summary: sys-fs/avfs-0.9.7 version bump (no more cvs :))
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Stefan Schweizer (RETIRED)
URL: http://sourceforge.net/projects/avf
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks: 133868
  Show dependency tree
 
Reported: 2006-06-14 14:23 UTC by Peter Hyman
Modified: 2006-07-19 03:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
avfs-0.9.7.ebuild (avfs-0.9.7.ebuild,2.04 KB, text/plain)
2006-06-14 14:24 UTC, Peter Hyman
Details
avfs-0.9.7.ebuild (avfs-0.9.7.ebuild,2.00 KB, text/plain)
2006-06-15 02:09 UTC, Peter Hyman
Details
avfs-0.9.7.ebuild (avfs-0.9.7.ebuild,1.40 KB, text/plain)
2006-06-15 08:03 UTC, Peter Hyman
Details
avfs-0.9.7.ebuild (last one, really!) (avfs-0.9.7.ebuild,1.40 KB, text/plain)
2006-06-15 10:44 UTC, Peter Hyman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Hyman 2006-06-14 14:23:10 UTC
This ebuild represents a stabilized version of avfs which no longer relies on cvs. This update includes the same features as avfs-0.9.7_p? (namely fuse support on 2.6.x kernels) without the cvs hassles! Regrettably, I chose to use _p for the existing ebuild instead of _pre so this will appear as a downgrade, which it is not. The enhancement is a change in the configure.in script which compensates for a fuse shortcoming wrt -DFILE_OFFSET_BITS=64 and 64 bit processors. Bug #133868 highlighted this. So, Stefan, I suppose when you review and commit, might as well kill the existing avfs-0.9.7_p20060517. I do not have access to an amd64 machine, but based on the reports from bug #133868, you may wish to consider adding ~amd64 to the keywords. Jose, please comment!
Comment 1 Peter Hyman 2006-06-14 14:24:17 UTC
Created attachment 89207 [details]
avfs-0.9.7.ebuild
Comment 2 José Romildo Malaquias 2006-06-14 16:11:39 UTC
Your ebuild installs without problems for me.

A quick test shows that it also works on ~amd64:

$ mountavfs
Mounting AVFS on /home/romildo/.avfs...
$ cd ~/.avfs/usr/local/portage/distfiles/aalib-1.4rc5.tar.gz#/aalib-1.4.0/
$ wc README
  91  543 3604 README
$ cd
$ umountavfs
unMounting AVFS on /home/romildo/.avfs...
Comment 3 Stefan Schweizer (RETIRED) gentoo-dev 2006-06-14 16:53:21 UTC
cant we just use a standard emake install instead of all the manual doexe'ing?

A few other issues:
- use RDEPEND - the portage version does that already, uh?
- use kernel_is 2 6
- your check in pkg_setup does not work because linux-mod-pkg_setup is not called
- dont CONFIG_CHECK fuse can be built externally
- make <-> emake, uh?

sorry, this has degraded from portage. Since I believe you also know what is wrong I think you should put a little more effort in it, please.

Comment 4 Peter Hyman 2006-06-14 19:28:16 UTC
(In reply to comment #3)
> cant we just use a standard emake install instead of all the manual doexe'ing?
> 
No. Make install puts lots of unneeded stuff unrelated to fuse support. I'd end up removing stuff from ${D} manually. There's a comment to that effect in the ebuild.

> A few other issues:
> - use RDEPEND - the portage version does that already, uh?
> - use kernel_is 2 6

Dangers of cut and paste. I'll have to review...

> - your check in pkg_setup does not work because linux-mod-pkg_setup is not
> called
> - dont CONFIG_CHECK fuse can be built externally
> - make <-> emake, uh?
> 
No. There are two issues. One Fuse support must be enabled in the kernel. Two, fuse libraries must be installed. Now, I assume you're thinking, well if the fuse libraries are installed, let it do the kernel check. However, the 2.6 kernel check still has to be done. So relying on fuse installation alone is not sufficient I think.

> sorry, this has degraded from portage. Since I believe you also know what is
> wrong I think you should put a little more effort in it, please.
> 
I'll take a closer look and see what's changed since the last version of portage. Since the ebuild is identical with the prior version minus cvs support, these issues are new to me. You did not raise them before. FWIW repoman didn't seem to post anything.
Comment 5 Peter Hyman 2006-06-15 02:09:34 UTC
Created attachment 89235 [details]
avfs-0.9.7.ebuild

Removes 
- CONFIG_CHECK FUSE_FS since fuse library will install kernel module if not built into kernel
- direct call to linux-mod-pkg_setup and kernel version check hack
Adds 
- RDEPEND
- kernel_is lt 2 6 (since fuse can compile on 2.4)
Changes
- direct call to chmod to fperms.
Comment 6 Peter Hyman 2006-06-15 08:03:04 UTC
Created attachment 89248 [details]
avfs-0.9.7.ebuild

Let's see if three times is the charm.

Changes: streamline pkg_setup, use emake/einstall and remove cruft, cleaned up whitespaces.
Comment 7 Peter Hyman 2006-06-15 10:44:24 UTC
Created attachment 89258 [details]
avfs-0.9.7.ebuild (last one, really!)

corrects whitespace (so much for trying to be neat) and corrects removal of /etc in ${D}. B/c of einstall, no longer /usr/etc, just /etc. Still needs to go.
Comment 8 Stefan Schweizer (RETIRED) gentoo-dev 2006-07-19 03:32:42 UTC
I added this to portage, thanks