Bug 136406 – rox.eclass missing quotes

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Peter Hyman 2006-06-11 07:14:25 UTC]

The following snippet results in incorrect evaluation of $KEEP_SRC. The variable should have been quoted.

		if [ -n ${KEEP_SRC} ]; then
			( cd src
			make clean
			)
		else
			rm -rf src
		fi

[Comment 1 Peter Hyman 2006-06-11 07:16:06 UTC]

Created attachment 88908 [details]
rox.eclass

corrects unquoted variable in -n test. 

if [ -n "${KEEP_SRC}" ] instead of
if [ -n ${KEEP_SRC} ]

[Comment 2 Daniel Black (RETIRED) 2006-06-11 16:18:29 UTC]

Created attachment 88944 [details, diff]
rox.eclass.diff

May as well go all the way. Tell me if I've "corrected" too far.

[Comment 3 Daniel Black (RETIRED) 2006-06-11 16:18:57 UTC]

commited