I applied aacgain 1.5 to my music collection containing several hundred AAC files. It corrupted them, seemingly at random (which files it corrupts is always the same but the selection appears to be without a particular pattern). The files it corrupts will no longer play in any music player, including mplayer. The OTHER files still work with most things, but NOT with faad. faad2 goes into an infinite loop, lseeking to the same position over and over again, trying to read the files to which aacgain successfully applied a gain tag. Please hard-mask this package or place major warnings on it. Emerge --info: Portage 2.1_rc4-r3 (default-linux/amd64/2006.0, gcc-4.1.1, glibc-2.3.6-r3, 2.6.16-gentoo-r7 x86_64) ================================================================= System uname: 2.6.16-gentoo-r7 x86_64 AMD Athlon(tm) 64 X2 Dual Core Processor 4600+ Gentoo Base System version 1.12.0 ccache version 2.3 [enabled] dev-lang/python: 2.4.2 dev-python/pycrypto: 2.0.1-r5 dev-util/ccache: 2.3 dev-util/confcache: [Not Present] sys-apps/sandbox: 1.2.17 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1 sys-devel/binutils: 2.16.1-r2 sys-devel/gcc-config: 1.3.13-r2 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="amd64" AUTOCLEAN="yes" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe -fomit-frame-pointer -march=k8" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/bind /var/qmail/alias /var/qmail/control" CONFIG_PROTECT_MASK="/etc/gconf /etc/splash /etc/terminfo /etc/env.d" CXXFLAGS="-O2 -pipe -fomit-frame-pointer -march=k8" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig ccache distlocks fixpackages maketest metadata-transfer parallel-fetch sandbox sfperms strict test" GENTOO_MIRRORS="http://www.gtlib.gatech.edu/pub/gentoo http://gentoo.mirrors.pair.com/ http://gentoo.mirrors.easynews.com/linux/gentoo/ " LC_ALL="en_US.UTF-8" LINGUAS="en" MAKEOPTS="-j3" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude='/distfiles' --exclude='/local' --exclude='/packages'" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/portage-overlay" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="amd64 7zip X X509 a52 aac aalib acl acpi aim alsa amarok amazon amd amuled apache2 asf async authdaemond automount avi bash-completion bcmath bdf berkdb big-tables bootsplash branding browserplugin bzip2 cairo cap caps ccache cdda cddb cdinstall cdio cdparanoia cdr cdrom cg chroot cjk cli crypt css ctype cups curl curlwrappers cvs cvsgraph cyrus dbus dga dio directfb dlloader dlopen dmx dnd dnotify doc dpms dri dts dv dvd dvdr dvdread dxr3 edl eds emul-linux-x86 encode enscript escreen ethereal evo evolution exif exscalibar extensions fam fame fastcgi fbcon fbsplash festival ffmpeg firefox flac flash flatfile font-server foomaticdb ftp fuse gaim gd ggi gif gimp gimpprint glut gmail gmailtimestamps gmp gnome gnome-print gpgme gpm grammar graphicsmagick graphviz gs gssapi gstreamer gstreamer010 gtk gtk2 gtkhtml gtkspell gvim hal hou hpn httpd iconv id3 idn ieee1394 ifp imagemagick imap imlib inifile innodb insecure-savers iproute2 ipsec ipv6 irc ithreads j2ee jack java javascript jboss jce jcs jikes john joystick jpeg jpeg2k junit kde kerberos lame largeterminal latex lcms ldap ldapsam ldirectord libcaca libsamplerate libvisual lirc lm_sensors log4j logrotate lzw lzw-tiff mad maildir math matroska mbrola md5sum mem-cache memcache menubar mime mjpeg mmap mng mod mod_python module mono moodbar mouse moznocompose moznoirc moznomail mp3 mp4 mp4live mpeg mpeg2 mplayer mpm-worker msdfs mudflap multiuser musepack musicbrainz mysql mysqli nas ncurses net nethack network nfs nls nocd nosrc nowin nptl nptlonly nsplugin ntfs ntlm nvidia nvtv objc objc++ odbc ogg oggvorbis opengl openssl oscar oss overlays pam pam_chroot pam_console passfile pcntl pcre pcsc-lite pdf pdflib perl php player plotutils png pop ppds pppd python qemu-fast qt quicktime rar rdesktop readline reflection reiserfs remote rtc samba sasl screen sdl sensord server servlet-2.4 session sftp silvercity skey slang slp smartcard smarty smime smp smtp sockets socks5 sou spell spl sql sse-filters ssl startup-notification stream subtitles subversion svg swarmcache sysfs syslog tabs taglib tagwriting tcpd test tetex thesaurus threads tidy tiff timidity tokenizer toolbar transcode truetype truetype-fonts type1-fonts underscores unicode unzip urandom usb userlocales utf8 v4l v4l2 vcd vhosts vim vim-pager visualization vorbis webdav webkdc widescreen wifi winbind wma wma123 wmf wxwindows x264 xcomposite xext xgetdefault xine xinerama xlockrc xml xml2 xmldoclet xmlreader xmlrpc xmlwriter xmms xorg xosd xpm xprint xrandr xscreensaver xsettings xv xvid xvmc yv12 zip zlib elibc_glibc input_devices_mouse input_devices_evdev input_devices_joystick input_devices_keyboard kernel_linux linguas_en userland_GNU video_cards_nvidia video_cards_vesa video_cards_fbdev" Unset: CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS
I have to investigate it further. If I find further evidence of corrupted files, I will mask it. Otherwise I will place a warning.
I found this one: http://www.hydrogenaudio.org/forums/lofiversion/index.php/t32062.html I decide later what to do...
If I understand it right, there *was* an issue with aacgain prior to version 1.3 where the temp-file/optimize problem was fixed. But we're talking about version 1.5. You're using 'amd64'. so it's a 64-Bit issue maybe. Or an amd64/gcc4 issue.
ok, I added a BIG FAT WARNING for the time being. I googled for a while but found only the hydrogenaudio.org discussion about versions prior 1.3. Since it is ~arch, I prefer not masking it yet, but add the warning from the homepage to pkg_postinst(): "BACK UP YOUR MUSIC FILES BEFORE USING AACGAIN! THIS IS EXPERIMENTAL SOFTWARE. THERE HAVE BEEN BUGS IN PAST RELEASES THAT CORRUPTED MUSIC FILES." please reopen if you don't agree or if you have further evidence of a general problem with version 1.5. Thanks!
(In reply to comment #4) > ok, I added a BIG FAT WARNING for the time being. > > I googled for a while but found only the hydrogenaudio.org discussion about > versions prior 1.3. Since it is ~arch, I prefer not masking it yet, but add the > warning from the homepage to pkg_postinst(): > > "BACK UP YOUR MUSIC FILES BEFORE USING AACGAIN! THIS IS EXPERIMENTAL SOFTWARE. > THERE HAVE BEEN BUGS IN PAST RELEASES THAT CORRUPTED MUSIC FILES." > > please reopen if you don't agree or if you have further evidence of a general > problem with version 1.5. Thanks! > This resolution is satisfactory for me - after all, it's not my problem anymore, I just won't use aacgain :-P. It could be gcc 4.1/amd64, or it could be the fact that I have my music collection on AFS - who knows what that does to programs like aacgain. Either way, it was aacgain 1.5 that corrupted the files, without warning. I'm on RAID-5, it's not disk corruption, and my OpenAFS handles all other transfers just fine, so I have no reason to believe it's OpenAFS producing the bad files.
