Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 136076 - kernel-2 eclass K_EXTRAEINFO/WARN enhancement
Summary: kernel-2 eclass K_EXTRAEINFO/WARN enhancement
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: John Mylchreest (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-08 08:21 UTC by Peter Hyman
Modified: 2006-07-22 12:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kernel-2.eclass.diff (kernel-2.eclass.diff,1.69 KB, patch)
2006-06-08 08:22 UTC, Peter Hyman
Details | Diff
kernel-2.eclass.diff (kernel-2.eclass.diff,2.69 KB, patch)
2006-06-10 04:14 UTC, Peter Hyman
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Hyman 2006-06-08 08:21:29 UTC
The attached patch adds two variables to the kernel-2 eclass to extend functionality: K_EXTRAEINFO_F and K_EXTRAEWARN_F. The _F stands for format which allows users to embed \n and \t in the K_EXTRAE* text strings. Later, during the postinst_sources function, echo -e is used in conjuction with fmt -w75 -s in order to print nicely formatted output. I did this because I wanted a line break in the middle of a string I had, but fmt kept wrapping all text together. This enhancement allows the user to optionally choose to use the _F and format his/her K_EXTRA* string. The patch does not modify any existing code so current functionality is maintained.
Comment 1 Peter Hyman 2006-06-08 08:22:25 UTC
Created attachment 88690 [details, diff]
kernel-2.eclass.diff

patch to add capability to print formatted K_EXTRAEINFO/WARN output.
Comment 2 Peter Hyman 2006-06-10 04:13:13 UTC
A new enhancement has been added which allows the user to set a flag UNIPATCH_GENPATCHES_LAST which will permit the application of custom patchsets (a la ck, beyond) PRIOR to the application of genpatches. This will remove many patch errors that result when genpatches are applied first.
Comment 3 Peter Hyman 2006-06-10 04:14:02 UTC
Created attachment 88829 [details, diff]
kernel-2.eclass.diff

adds UNIPATCH_GENPATCHES_LAST flag and application in unipatch function.
Comment 4 Daniel Drake (RETIRED) gentoo-dev 2006-06-10 04:23:34 UTC
That limits what ebuilds can do somewhat. I think it would be better to leave existing behaviour as-is, but add another list variable which contains patches to be applied after genpatches. That way an ebuild can specify patches to be applied both before and after.
Comment 5 Peter Hyman 2006-06-10 05:03:46 UTC
Comment on attachment 88829 [details, diff]
kernel-2.eclass.diff

patch order patch moved to  136271 per dsd.
Comment 6 Peter Hyman 2006-06-14 11:24:44 UTC
John, per your request, this is the enhancement bug. If you're on the kernel@g.o email, then just remove the duplicate cc. 

In regards to: "however on immediate thought I can't see why formatting this can't be applied to the main variables."

All text just wraps together and split lines are joined. fmt does this. Using echo -e and making some small changes to fmt fixes this (unless I missed something obvious!)
Comment 7 Peter Hyman 2006-07-22 12:34:23 UTC
upstream inaction.