Bug 135782 – incorrporate KDE bugfix for khtml in the appropriate ebuild

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description rick vernam 2006-06-06 08:46:22 UTC]

I really don't know how to get a patch incorporated into an ebuild...here are the patches as they came in an email from bugs.kde.com (affects 3.5.3 only):

http://bugs.kde.org/show_bug.cgi?id=128710 

[Comment 1 rick vernam 2006-06-06 08:46:22 UTC]

I really don't know how to get a patch incorporated into an ebuild...here are the patches as they came in an email from bugs.kde.com (affects 3.5.3 only):

http://bugs.kde.org/show_bug.cgi?id=128710         
kde carewolf com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From kde carewolf com  2006-06-06 13:04 -------
SVN commit 548707 by carewolf:

If :hover is part of a subselector it doesn't fall under 
the hoveractive-only quirk (REGRESSION)
BUG: 128710


 M  +4 -4      cssstyleselector.cpp  
 M  +1 -1      cssstyleselector.h  


--- branches/KDE/3.5/kdelibs/khtml/css/cssstyleselector.cpp #548706:548707
 @ -1021,7 +1021,7  @
         //kdDebug() << "CSSOrderedRule::checkSelector" << endl;
         ElementImpl *elem = static_cast<ElementImpl *>(n);
 
-        if(!checkOneSelector(sel, elem, isAncestor)) return 0;
+        if(!checkOneSelector(sel, elem, isAncestor, true)) return 0;
         //kdDebug() << "CSSOrderedRule::checkSelector: passed" << endl;
         break;
     }
 @ -1054,7 +1054,7  @
     return;
 }
 
-bool CSSStyleSelector::checkOneSelector(DOM::CSSSelector *sel, DOM::ElementImpl *e, bool isAncestor)
+bool CSSStyleSelector::checkOneSelector(DOM::CSSSelector *sel, DOM::ElementImpl *e, bool isAncestor, bool isSubSelector)
 {
     if(!e)
         return false;
 @ -1433,7 +1433,7  @
         case CSSSelector::PseudoHover: {
            // If we're in quirks mode, then *:active should only match focusable elements, and never
            // unfocusable anchors.
-           if (strictParsing || (sel->tag != anyQName && e->id() != ID_A) || e->isFocusable()) {
+           if (strictParsing || ((sel->tag != anyQName || isSubSelector) && e->id() != ID_A) || e->isFocusable()) {
                 doc->dynamicDomRestyler().addDependency(element, e, HoverDependency);
 
                 if (e->hovered())
 @ -1443,7 +1443,7  @
         }
        case CSSSelector::PseudoActive:
            // If we're in quirks mode, then *:active should only match focusable elements
-           if (strictParsing || (sel->tag != anyQName && e->id() != ID_A) || e->isFocusable()) {
+           if (strictParsing || ((sel->tag != anyQName || isSubSelector) && e->id() != ID_A) || e->isFocusable()) {
                 doc->dynamicDomRestyler().addDependency(element, e, ActiveDependency);
 
                if (e->active())
--- branches/KDE/3.5/kdelibs/khtml/css/cssstyleselector.h #548706:548707
 @ -152,7 +152,7  @
            with given relationships matches the given Element */
        void checkSelector(int selector, DOM::ElementImpl *e);
        /* checks if the selector matches the given Element */
-       bool checkOneSelector(DOM::CSSSelector *selector, DOM::ElementImpl *e, bool isAncestor);
+       bool checkOneSelector(DOM::CSSSelector *selector, DOM::ElementImpl *e, bool isAncestor, bool isSubSelector=false);
 
 #ifdef APPLE_CHANGES
        /* This function fixes up the default font size if it detects that the

[Comment 2 rick vernam 2006-06-06 08:47:51 UTC]

ah, I see now that I should have put the patch stuff in an attachment.
I'll know that for next time...

[Comment 3 Carsten Lohrke (RETIRED) 2006-06-06 09:37:34 UTC]

Looking into it. Have another fix pending anyways.

[Comment 4 Carsten Lohrke (RETIRED) 2006-06-14 16:57:14 UTC]

fixed with kdelibs-3.5.3-r2