Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 134994 - eutils.eclass use bootstrap flag, but doesn't set IUSE
Summary: eutils.eclass use bootstrap flag, but doesn't set IUSE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-31 01:47 UTC by Brian Harring (RETIRED)
Modified: 2006-06-07 10:39 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Harring (RETIRED) gentoo-dev 2006-05-31 01:47:30 UTC
So... eutils.eclass tags on !bootstrap? ( patch ) dep, which is good and dandy, 'cept it doesn't set IUSE=bootstrap.

Portage (.50-r10 iirc, and up) stacks IUSE across eclasses/ebuild, so the setting would survive fine- so.... that should be corrected.

Downside, quick scan of all consumers of eutils shows the count at 14,024 ebuilds.  So... to fix this requires regen'ing 60% of the tree metadata (hence the infra cc'ing).

Might seem stupid, but this *does* need fixing- if anyone attempts a feature limiting what's set for USE to what's stated in IUSE (qa measure), it's fairly horked because of this- additionally, any scan of the tree for unstated IUSE requires black listing bootstrap, which is *bad*.

Upshot, 14013 ebuilds use bootstrap without stating it, eutils change fixes 13977 of 'em.

round two of submission btw- hopefully this isn't a dupe, bugzie went 500 on me...
Comment 1 solar (RETIRED) gentoo-dev 2006-05-31 02:35:58 UTC
I'd rather see the !bootstrap? ( patch ) yanked and make sure patch is in every stageball & packages file.
Comment 2 solar (RETIRED) gentoo-dev 2006-05-31 02:46:35 UTC
base/packages has *sys-devel/patch so this dep looks duff to me.
Anybody see a reason to force this dep? Adding the bootstrap flag to
everything that inherits eutils would litter up the namespace for
seemingly no good reason.
Comment 3 Brian Harring (RETIRED) gentoo-dev 2006-05-31 02:59:36 UTC
eenie meenie.  Personally, implicit deps suck worse for me then daft deps (anything that takes info away from the resolver is bad, essentially).

Either way, any change is going to kick osprey in the nuts regen wise.
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2006-05-31 14:50:45 UTC
Why exactly was I added to this bug?
Comment 5 solar (RETIRED) gentoo-dev 2006-05-31 15:13:09 UTC
(In reply to comment #4)
> Why exactly was I added to this bug?

I added you cuz you are apart of releng and maybe know of a pitfall 
with the solution presented in comment #1 or maybe know otherwise.
If you have nothing to add to the bug feel yank yourself.

Comment 6 Chris Gianelloni (RETIRED) gentoo-dev 2006-06-01 11:23:38 UTC
I can't see any reason why it should affect anything.  As it is, we already pull in patch during a stage1 build.  It is listed in packages.build for default-linux.  It also appears to be in hardened.  The packages file controls "system", whereas packages.build controls the stage1 tarball.  It must be in packages.build, or bad things happen.  I see no harm in removing it other than it being more implicit dependencies, which I don't like much myself.
Comment 7 SpanKY gentoo-dev 2006-06-07 10:39:55 UTC
dropped bootstrap/patch from eutils.eclass since it's part of base/packages and default-linux/packages.build