Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 134834 - graphviz 2.8 produces black pictures
Summary: graphviz 2.8 produces black pictures
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo Graphics Project
URL: http://www.graphviz.org/bugs/b922.html
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-29 15:22 UTC by Ikar
Modified: 2006-10-06 11:46 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Input to dot that will draw a simple UML type class file (class.dot,428 bytes, text/plain)
2006-05-31 09:57 UTC, Bill Krueger
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ikar 2006-05-29 15:22:09 UTC
it's a graphviz bug and should already have been repared:

http://www.graphviz.org/bugs/b922.html

can someone update ebuild?
Comment 1 Bill Krueger 2006-05-31 09:57:49 UTC
Created attachment 87999 [details]
Input to dot that will draw a simple UML type class file


The command I use to process the attached file is:

dot -Tpng -o class.png class.dot

and use something like firefox or kuickshow to view the image file created in class.png. Using graphviz-2.6-r1 produces the expected image. Using graphviz-2.8 produces the same size image that's entirely black.
Comment 2 Urs Joss 2006-06-04 22:56:31 UTC
same here...
Comment 3 Urs Joss 2006-06-05 05:20:28 UTC
I've emerged the development snapshot (today 2.9.20060604.0440) by renaming the original ebuild (had to comment out the notcl patch on line 38.).

The problem of this ebuild doesn't occur anymore. Haven't done any heavy testing and thus don't know if some other issues turn up.

HTH, Urs
Comment 4 Stefano Tamagnini 2006-07-08 07:08:08 UTC
This bug exist only with png,tiff,jpg infact with svg the image are correct;
Comment 5 Patrick ALLAERT 2006-09-14 05:05:32 UTC
Don't understand why graphviz 2.8 has been marked stable on x86 with such a blocking [1] bug!

[1] GraphViz used only to render (in PNG) dynamic graphs in a web-application.
Comment 6 Patrick ALLAERT 2006-09-14 07:25:20 UTC
exists upstream:

http://www.graphviz.org/bugs/b922.html
Comment 7 Gabor Drasny 2006-09-19 10:55:16 UTC
I had the same problem, and the easy solution was to do
  LC_ALL=C emerge graphviz

(My original setting of LC_ALL was en_US.utf8. In graphviz lib/common/Makefile.am contains a rule that sorts color names by using LC_COLLATE=C $(SORT) ..., but LC_COLLATE has no effect when LC_ALL is set, so the color names ended up listed in the wrong order.)
Comment 8 Chris Bainbridge (RETIRED) gentoo-dev 2006-09-21 14:05:17 UTC
It seems that nobody cares about graphviz... so I've gone ahead and commited the LC_ALL based fix.
Comment 9 SpanKY gentoo-dev 2006-09-21 15:28:55 UTC
that is a workaround, not a fix
Comment 10 Harald van Dijk (RETIRED) gentoo-dev 2006-09-22 04:37:41 UTC
> that is a workaround, not a fix

It's not the perfect fix, since LC_ALL=C is applied to the whole compilation, rather than just the sort command, but in what way is it not a fix at all?
Comment 11 SpanKY gentoo-dev 2006-09-22 10:40:02 UTC
a fix is something applied to the source code that fixes the root cause and then you would send it upstream

a workaround is none of these things, yet the final result still works
Comment 12 Harald van Dijk (RETIRED) gentoo-dev 2006-09-22 11:10:25 UTC
The root issue is that the sort command does not compare the same way as strcmp() does. The fix is to do sort using a strcmp()-compatible comparison function. LC_ALL=C is the way to do this (for ASCII systems -- which last time I asked was an acceptable assumption for Gentoo). Your distinction between things that can be sent upstream and things that can't is an important one, but a different one. There are ebuilds that contain the build system in themselves, and using your meaning of "fix" it's impossible to fix /anything/ that gets broken by them. This issue is fixed.
Comment 13 SpanKY gentoo-dev 2006-09-22 11:37:17 UTC
is the `sort` in the ebuild ?  no ?  then LC_ALL does not belong in the ebuild

if the call to `sort` in the graphviz build system needs standard ASCII sorting, then you patch the graphviz build system to use LC_ALL=C *only* when calling sort

if someone told you that inserting LC_ALL into ebuilds is acceptable, they were wrong
Comment 14 Harald van Dijk (RETIRED) gentoo-dev 2006-09-22 11:45:50 UTC
I already acknowledged that it would have been better to use LC_ALL=C only for the sort call. You're avoiding addressing my point. (And since I doubt you will change that after this: don't feel a need to reply to this.)
Comment 15 SpanKY gentoo-dev 2006-09-22 13:02:12 UTC
i didnt avoid your point, i addressed it pretty clearly

the issue here is that the makefile is broken ... thus your section about the ebuild being the build system is irrelevant

this bug is not fixed until the Makefile is patched and sent upstream ... so long as LC_ALL is in the ebuild and not the Makefile, it is a workaround and the bug report stays open
Comment 16 SpanKY gentoo-dev 2006-10-06 11:46:18 UTC
fixed in cvs by changing LC_COLLATE in the makefile to LC_ALL