Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 134346 - [resolvconf-0.5] nameservers without search/domain
Summary: [resolvconf-0.5] nameservers without search/domain
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Roy Marples (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-25 10:19 UTC by Oldrich Jedlicka
Modified: 2006-05-25 11:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oldrich Jedlicka 2006-05-25 10:19:38 UTC
I think the resolfconf has a small typo in code:

for N in ${NS} ; do
  if [[ -n ${DOMAIN} ]] ; then
    NEWDOMAIN="${NEWDOMAIN} ${DOMAIN},${N}"
  elif [[ -n ${SEARCH} ]] ; then
    for S in ${SEARCH} ; do
      NEWSEARCH="${NEWSEARCH} ${S},${N}"
    done
  else
    NEWNS="${NEWNS} ${NS}"
  fi
done

The NEWNS line should be NEWNS="${NEWNS} ${N}", or there is a break command missing.
Comment 1 Roy Marples (RETIRED) gentoo-dev 2006-05-25 10:46:43 UTC
NEWNS is a space separated list of nameservers without any specific domain or search

NEWDOMAIN and NEWSEARCH are space separated lists of nameservers with the domain before it, comma separated.

This is how I designed it.
Comment 2 Oldrich Jedlicka 2006-05-25 11:10:30 UTC
Sorry, you probably do not understand the problem.

If there is no domain or search, then for every item in NS you add the FULL (!) NS into NEWNS. So the NS is in NEWNS as many times as the number of name servers. Of course, uniquify will fix the problem, but the problem is still there and this could cause problems in future development...
Comment 3 Roy Marples (RETIRED) gentoo-dev 2006-05-25 11:42:52 UTC
Fixed in resolvconf-gentoo-0.6 - thanks