Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 134312 - net-dialup/isdn4k-utils-3.9_pre20060124, hisax init script, stop fails
Summary: net-dialup/isdn4k-utils-3.9_pre20060124, hisax init script, stop fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Stefan Briesenick (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-25 04:38 UTC by Thomas
Modified: 2006-09-10 08:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas 2006-05-25 04:38:37 UTC
There is a little bug in the /etc/init.d/hisax init script, in the stop() section. Please find the following line (3rd line from end of file):

/sbin/modprobe -sqr hisax_fcpcipnp && /sbin/modprobe -sqr hisax

IMO the two "&&" should be replaced with a "||", otherwise it fails unloading the "hisax_fcpcipnp" module on a system that only has the "hisax" module, aborts the stop() operation with an error and lets the "hisax" module remain loaded.
Comment 1 Stefan Briesenick (RETIRED) gentoo-dev 2006-05-25 07:13:46 UTC
"/sbin/modprobe -sqr <module>" returns 0 if there is no *real* error (at least it does when I tested it), so && should work fine.

nonetheless || would be completely wrong if you have both modules loaded. So the only solution is to run both modprobe's unconditionally.

I will change this.
Comment 2 Stefan Briesenick (RETIRED) gentoo-dev 2006-09-10 08:36:05 UTC
finally fixed in CVS.