Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 134206 - keyword jakarta-jstl-1.1.2 for ppc
Summary: keyword jakarta-jstl-1.1.2 for ppc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: PPC Linux
: High enhancement
Assignee: Java team
URL: http://forums.gentoo.org/viewtopic-t-...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-24 06:59 UTC by Aymeric Nys
Modified: 2006-09-13 20:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
jakarta jstl 1.1.2 ebuild (jakarta-jstl-1.1.2.ebuild,2.38 KB, text/plain)
2006-05-24 07:00 UTC, Aymeric Nys
Details
Patch to the build.xml ant file (bootclasspath.patch,705 bytes, patch)
2006-05-24 07:02 UTC, Aymeric Nys
Details | Diff
new ebuild with new patch (jakarta-jstl-1.1.2.ebuild,2.39 KB, text/plain)
2006-05-25 11:45 UTC, Aymeric Nys
Details
remove bootclasspath from build.xml (remove-bootclasspath.patch,585 bytes, patch)
2006-05-25 11:45 UTC, Aymeric Nys
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aymeric Nys 2006-05-24 06:59:07 UTC
Hi there,
jakarta-jstl should emerge fine for x86 but I need it on ppc so I modify the ebuild to get it work on ppc with ibm-jdk (1.4.2_04).
I described the process on a post on the forum.
Also I'll add the files as attachement with this bug.
If people could comment (it's my first ebuild modification) I could learn and help further (I'd like to).
Comment 1 Aymeric Nys 2006-05-24 07:00:36 UTC
Created attachment 87392 [details]
jakarta jstl 1.1.2 ebuild
Comment 2 Aymeric Nys 2006-05-24 07:02:04 UTC
Created attachment 87394 [details, diff]
Patch to the build.xml ant file

build.xml is made for a sun-jdk. ibm break down the file rt.jar in 3 or 4 differents files.
Comment 3 Joe Jezak (RETIRED) gentoo-dev 2006-05-24 14:45:30 UTC
What does the java team think about these changes?
Comment 4 Josh Nichols (RETIRED) gentoo-dev 2006-05-25 06:21:04 UTC
My first impression is that the build.xml probably doesn't need to specify the bootclasspath, since it should already be setup. So, I'd suggest patching to remove the bootclasspath of javac, and see if that works on both sun-jdk and ibm-jdk.
Comment 5 Aymeric Nys 2006-05-25 11:43:01 UTC
(In reply to comment #4)
> My first impression is that the build.xml probably doesn't need to specify the
> bootclasspath, since it should already be setup. So, I'd suggest patching to
> remove the bootclasspath of javac, and see if that works on both sun-jdk and
> ibm-jdk.
> 
Your first impression is correct. I patch to remove the classpath, and it works the same (ppc, ibm-jdk). I post the new ebuild and the patch.
Comment 6 Aymeric Nys 2006-05-25 11:45:00 UTC
Created attachment 87499 [details]
new ebuild with new patch
Comment 7 Aymeric Nys 2006-05-25 11:45:41 UTC
Created attachment 87500 [details, diff]
remove bootclasspath from build.xml
Comment 8 Josh Nichols (RETIRED) gentoo-dev 2006-05-25 12:03:52 UTC
For future reference, it is preferred to submit patches against ebuilds, rather than the entire ebuild. This makes it possible to quickly determine how the ebuild has been changed.

But I'm glad to here it could be fixed. Might I suggest you submit a bug with patch upstream as well?
Comment 9 Josh Nichols (RETIRED) gentoo-dev 2006-09-13 10:41:56 UTC
Comment on attachment 87500 [details, diff]
remove bootclasspath from build.xml

Patch applied to ebuild in CVS.
Comment 10 Josh Nichols (RETIRED) gentoo-dev 2006-09-13 20:07:22 UTC
Fixed in CVS. Thanks for reporting! Sorry about the delay.