Bug 134048 – dev-libs/zziplib-0.13.45 does not compile on Gentoo/FBSD

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Robert Sebastian Gerus 2006-05-22 12:36:32 UTC]

dev-libs/zziplib-0.13.45 does not compile on Gentoo/FBSD. a typical missing #include <sys/types.h> (I actually start to wonder if it's not actually some auto* issue)

[Comment 1 Robert Sebastian Gerus 2006-05-22 12:37:23 UTC]

Created attachment 87273 [details, diff]
zziplib-0.13.45-freebsd.patch

[Comment 2 Diego Elio Pettenò (RETIRED) 2006-05-22 15:01:58 UTC]

I would put it either unconditional or under autoconf check.

Vapier, Mr_Bones_, tell me what you prefer :)

[Comment 3 Mr. Bones. (RETIRED) 2006-05-22 20:07:58 UTC]

I don't have a problem with it being unconditional.  sys/types.h should always be available for unix.

[Comment 4 SpanKY 2006-05-22 23:43:29 UTC]

well lets look at the rest of the code

zzipwrap/wrap.c always includes sys/types.h

zzip/file.h checks ZZIP_HAVE_SYS_TYPES_H

pick your poison and make sure you send it upstream :P

[Comment 5 Diego Elio Pettenò (RETIRED) 2006-05-23 05:38:55 UTC]

Actually upstream already resolved this. Anyway, patch applied with unconditional sys/types.h and keyword added. Thanks Robert, thanks guys :)