Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 133594 - Needless license duplication in X.org 7.0 ebuilds
Summary: Needless license duplication in X.org 7.0 ebuilds
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Low trivial (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
: 181377 258033 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-05-17 06:33 UTC by Stephan Sokolow
Modified: 2009-02-07 16:25 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Sokolow 2006-05-17 06:33:10 UTC
While running a little script I whipped up to show all packages with licenses not on a list I OKed, I noticed that every X.org 7.0 package has it's own license. 

On a hunch, I ran `fdupes /usr/portage/licenses/`. My suspicions were confirmed and I really think that the maintainers should also run it. 

fdupes does byte-for-byte comparison, so the amount of duplication will probably appear much higher when checked using something which ignores differing whitespace.

If there's any way I can help out with this, just ask.
Comment 1 Carsten Lohrke (RETIRED) gentoo-dev 2006-05-17 07:34:13 UTC
Yes, noticed this a while ago, too. This thwarts any approach to make use of the LICENSE variable to implement proper license management, is therefore quite annoying and imho not acceptable.
Comment 2 Joshua Baergen (RETIRED) gentoo-dev 2006-05-17 20:38:00 UTC
It's very difficult to created a unified license for the X packages.  A vast majority of the packages do not have proper licensing files, and so many licenses are derived from the code.

Now that things have settled down upstream, it might be safe to merge some of these licenses (although how to name them is another issue).  However, we can only merge exact duplicates (content-wise) as far as I know, even if only the copyrights differ.

(In reply to comment #1)
> Yes, noticed this a while ago, too. This thwarts any approach to make use of
> the LICENSE variable to implement proper license management, is therefore quite
> annoying and imho not acceptable.
> 

This point did not come up (iirc) in the discussion about these licenses on the gentoo-dev list several months ago.
Comment 3 Stephan Sokolow 2006-05-17 20:44:12 UTC
I definitely agree that naming will be a problem.

On the plus side, fdupes says that there are at least a dozen of them in the largest of the byte-for-byte identical groupings as well as 4 or 5 additional groups of 2-4 identical licenses, and I didn't try a whitespace-insensitive comparison.
Comment 4 Donnie Berkholz (RETIRED) gentoo-dev 2006-08-27 03:07:48 UTC
With around 300 packages in modular X, it's my opinion that the additional maintenance burden of trying to deal with some of them being identical and some not is not worth the time involved for something that very few people care about.
Comment 5 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-05 16:30:33 UTC
Closing, see comment #4.
Comment 6 Ciaran McCreesh 2006-09-05 16:50:34 UTC
You're aware that this breaks GLEP 23, which is a GLEP that has been accepted by the council and is being implemented?
Comment 7 Ilya Volynets (RETIRED) gentoo-dev 2006-09-05 16:56:33 UTC
Reopenning. See comment #6
Comment 8 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-09-05 17:20:44 UTC
(In reply to comment #6)
> You're aware that this breaks GLEP 23, which is a GLEP that has been accepted
> by the council and is being implemented?
> 

Incorrect, the GLEP has not been modified since 2004, accoring to GLEP 28, GLEP 23 is now deferred.
Comment 9 Ciaran McCreesh 2006-09-05 17:29:02 UTC
(In reply to comment #8)
> (In reply to comment #6)
> > You're aware that this breaks GLEP 23, which is a GLEP that has been accepted
> > by the council and is being implemented?
> 
> Incorrect, the GLEP has not been modified since 2004, accoring to GLEP 28, GLEP
> 23 is now deferred.

Which part of "GLEP 23 has been accepted by the council and is being implemented" is untrue?
Comment 10 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-09-05 17:43:39 UTC
If a Draft GLEP is inactive for more than 60 days or an Accepted GLEP is inactive for more than six months, then it would be marked as "deferred" on the main GLEP page [1]. Inactivity is defined simply as the GLEP author has not contacted the GLEP editors with either an update or a request to submit the GLEP for approval (in the case of a Draft GLEP) or a request that the GLEP be marked final (in the case of an Accepted GLEP).

So when have any of these things happened?
Comment 11 Ciaran McCreesh 2006-09-05 17:53:17 UTC
Your comments don't have any relevance to your claim that my initial claim is "incorrect". I repeat:

Which part of "GLEP 23 has been accepted by the council and is being
implemented" is untrue?
Comment 12 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-05 19:03:39 UTC
I don't see how this violates GLEP 23. Could you point out the section it violates?
Comment 13 SpanKY gentoo-dev 2006-09-05 19:04:08 UTC
*yawn* instead of bitching over details why not have someone post a patch to resolve the issue

Donnie has enough on his plate without having to worry over something stupid like LICENSE; if you care enough to complain, you care enough to fix it
Comment 14 Stephan Sokolow 2006-09-05 19:14:55 UTC
If nobody else has volunteered by the time I can find or make some time, I'll make a patch. What options should I be using when generating a patch against the portage tree?
Comment 15 Joshua Baergen (RETIRED) gentoo-dev 2006-09-05 20:27:09 UTC
Just make sure it's a unified patch (-u).  I use the options 'Naur', but if you're patching the license directory 'r' (recursive) and 'a' (forcibly compare things that don't look like text) will likely be pointless.
Comment 16 Jakub Moc (RETIRED) gentoo-dev 2006-09-11 08:34:37 UTC
(In reply to comment #14)
> If nobody else has volunteered by the time I can find or make some time, I'll
> make a patch. What options should I be using when generating a patch against
> the portage tree?

Instead of wasting time on this, I'd love to see a patch that changes those ebuilds' DESCRIPTION to something else that "X.org ${PN} application" (such as the NAME section from 'man ${PN}' output. That could be actually useful for many more users than shuffling with licenses that noone cares about.
Comment 17 Donnie Berkholz (RETIRED) gentoo-dev 2006-10-29 21:31:12 UTC
(In reply to comment #14)
> If nobody else has volunteered by the time I can find or make some time, I'll
> make a patch. What options should I be using when generating a patch against
> the portage tree?

Please reopen if/when this is supplied. I'm closing as WONTFIX because we won't be fixing this, but we are still open to patches. Thanks!

(In reply to comment #16)
> Instead of wasting time on this, I'd love to see a patch that changes those
> ebuilds' DESCRIPTION to something else that "X.org ${PN} application" (such as
> the NAME section from 'man ${PN}' output. That could be actually useful for
> many more users than shuffling with licenses that noone cares about.

I actually did this a few weeks ago, for all the ebuilds with accompanying man pages.
Comment 18 Stephan Sokolow 2006-10-29 22:05:01 UTC
Sorry I didn't carry through with it promptly. Shortly after saying I would, Murphy's law kicked in and my life has been so busy I've had to almost cut contact with the general open-source world in order to keep up.

I'll tag the e-mail notification of your message as TODO and get around to it when my life is again sane.
Comment 19 Jakub Moc (RETIRED) gentoo-dev 2007-06-09 07:03:27 UTC
*** Bug 181377 has been marked as a duplicate of this bug. ***
Comment 20 Harald van Dijk (RETIRED) gentoo-dev 2009-02-07 16:25:42 UTC
*** Bug 258033 has been marked as a duplicate of this bug. ***