Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 133473 - busy box fails to compile with -fstack-check
Summary: busy box fails to compile with -fstack-check
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: x86 Linux
: Normal trivial
Assignee: Embedded Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-16 04:28 UTC by Maurice Butler
Modified: 2006-05-20 23:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maurice Butler 2006-05-16 04:28:10 UTC
effects versions 1.0.0,1.1.0,1.1.2 with CFLAGS="-march=i686 -O2 -pipe -fstack-check"


/var/tmp/portage/busybox-1.1.2/work/busybox-1.1.2/coreutils/mv.c: In function `mv_main':
/var/tmp/portage/busybox-1.1.2/work/busybox-1.1.2/coreutils/mv.c:129: error: label 'RET_1' used before containing binding contour
make: *** [/var/tmp/portage/busybox-1.1.2/work/busybox-1.1.2/coreutils/mv.o]
Error 1

!!! ERROR: sys-apps/busybox-1.1.2 failed.
!!! Function src_compile, Line 129, Exitcode 2
!!! build failed
!!! If you need support, post the topmost build error, NOT this status message.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2006-05-16 04:35:19 UTC
So remove that flag from your make.conf?
Comment 2 solar (RETIRED) gentoo-dev 2006-05-16 04:56:17 UTC
-fstack-check is not a supported flag.
Comment 3 Maurice Butler 2006-05-16 14:16:34 UTC
(In reply to comment #2)
> -fstack-check is not a supported flag.

was in 2005.0, gentoo hardened and other flavours of linux included 

check page 90
http://dev.gentoo.org/~spyderous/articles/linux_development_platform/CH03.pdf

Comment 4 Maurice Butler 2006-05-16 14:18:30 UTC
(In reply to comment #2)
> -fstack-check is not a supported flag.

was in 2005.0, gentoo hardened and other flavours of linux included 

check page 90
http://dev.gentoo.org/~spyderous/articles/linux_development_platform/CH03.pdf

Comment 5 SpanKY gentoo-dev 2006-05-16 14:58:52 UTC
what's your point ?  there are a ton of flags provided by gcc
Comment 6 Maurice Butler 2006-05-17 00:06:31 UTC
(In reply to comment #5)
> what's your point ?  there are a ton of flags provided by gcc

There was no problem with this flag in 2005.0 as I had it set in the make.conf as it provides some protection against stack smash attacks. This was a flaw that was open to attack from badly written software in 2.4 and earlier kernels. Busybox should handle any compiler flags gracefully - even if it just ignores it.

Comment 7 Maurice Butler 2006-05-20 22:38:02 UTC
The problem relates to the "Basic" type use of goto's in mv.c - this is why the complier borks as it does not where the heck the stack is going
Comment 8 solar (RETIRED) gentoo-dev 2006-05-20 23:04:16 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > -fstack-check is not a supported flag.
> 
> was in 2005.0, gentoo hardened and other flavours of linux included 
> 

hardened uses -fstack-protector{,-all}
http://www.gentoo.org/proj/en/hardened/ (I'm one of the maintainers..)