Bug 133263 – drivers/macintosh/via-pmu.c variable testing not surrounded by ifdef's

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Andrew Griffiths 2006-05-13 22:35:42 UTC]

Doing a kernel compile on my powerbook failed in drivers/macintosh/via-pmu.c. The (soon to be) attached patch rectifies that issue. This patch may need to be applied to other kernels possibly.

[Comment 1 Andrew Griffiths 2006-05-13 22:36:58 UTC]

Created attachment 86730 [details, diff]
Patch to fix sleeping_in_progress not surrounded by #ifdef CONFIG_PM usage

[Comment 2 Kevin F. Quinn (RETIRED) 2006-05-14 13:47:26 UTC]

This isn't specific to hardened-sources; all current kernels have it.  Upstream have it fixed (a bit differently because they've introduced a new config value) in 2.6.17-rc4.

[Comment 3 Daniel Drake (RETIRED) 2006-05-15 08:43:14 UTC]

This is fixed in vanilla 2.6.16.

John, if you are still doing 2.6.14 stuff then here's a patch you can apply.

[Comment 4 John Mylchreest (RETIRED) 2006-05-16 04:52:34 UTC]

excellent. I'll push this into the repo hopefully this evening when I have access, and will merge in my cherrypicked fixes as well. I'll look to issue a new release in the coming week.

[Comment 5 Mike Pagano 2007-10-01 13:38:10 UTC]

As this has been in the mainline since 12/14/2005 I am closing.