Bug 132945 – dev-games/clanlib-0.6.5-r3 doesn't compile against dev-libs/DirectFB-0.9.25.1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description ferret 2006-05-10 13:34:24 UTC]

Compiling Sources/Display/System/Unix/directfb_target.cpp
Sources/Display/System/Unix/display_target.h:19: warning: 'class CL_DisplayTarget' has virtual functions but non-virtual destructor
Sources/Display/System/Unix/directfb_target.h:25: warning: 'class CL_DirectFBTarget' has virtual functions but non-virtual destructor
Sources/Display/Input/DirectFB/keyboard_directfb.cpp: In member function 'int CL_DirectFBKeyboard::map_directfb_to_cl(DFBInputDeviceKeyIdentifier)':
Sources/Display/Input/DirectFB/keyboard_directfb.cpp:246: error: 'DIKI_ALTGR' was not declared in this scope
Sources/Display/Input/DirectFB/keyboard_directfb.cpp: In member function 'DFBInputDeviceKeyIdentifier CL_DirectFBKeyboard::map_cl_to_directfb(int)':
Sources/Display/Input/DirectFB/keyboard_directfb.cpp:340: error: 'DIKI_ALTGR' was not declared in this scope
Sources/Display/Display/Generic/displaycard_generic.h:100: warning: 'class CL_DisplayCard_Generic::CL_FlipDisplayCallback_Generic' has virtual functions but non-virtual destructor
make: *** [Libs/Intermediate/keyboard_directfb.o] Error 1

[Comment 1 Håvard Wall 2006-05-11 00:57:04 UTC]

Created attachment 86592 [details, diff]
clanlib-0.6.5-r3-directfb.patch

The DIKI_ALTGR enum is removed in directfb-0.9.25. This patch checks for the directfb version before using DIKI_ALT_R instead as documented in the directfb release notes.

[Comment 2 ferret 2006-05-11 04:32:19 UTC]

Applied patch, works, looks good too (other than the logic assuming (correctly) that there wasn't ever a 0.8.25+, 0.7.25+, etc.)).

Happy with this. :)

[Comment 3 Håvard Wall 2006-05-11 10:11:20 UTC]

Created attachment 86614 [details, diff]
clanlib-0.6.5-directfb.patch

You are absolutely right (I should never submit quick fixes during coffee breaks at work). Here's my second attempt.

[Comment 4 SpanKY 2006-05-11 20:57:13 UTC]

Created attachment 86631 [details, diff]
clanlib-0.6.5-DirectFB-update.patch

still no good ... that patch would use DIKI_ALTGR for 0.10.1

try the attached instead

[Comment 5 ferret 2006-05-12 05:22:22 UTC]

typo in that patch; D_V should be DFB_V.  Otherwise it compiles fine.

[Comment 6 SpanKY 2006-05-12 19:36:44 UTC]

thanks for reviewing, now in portage