Bug 132928 – localmount: request for more robustness

• Status: VERIFIED FIXED
• Product: Gentoo Linux

[Description Mark Dominik Bürkle 2006-05-10 11:21:30 UTC]

Hi, 

if NET_FS_LIST is somehow empty then the whole "mount ..." command will fail because it's options are ending in "...,no".

Having alternate Text when NET_FS_LIST is set would make it more robust.

Kind regards,
mdb


# diff -wu /root/emerged_init.d_localmount /etc/init.d/localmount
--- /root/emerged_init.d_localmount 2006-05-07 20:59:55.000000000 +0200
+++ /etc/init.d/localmount      2006-05-10 20:02:10.000000000 +0200
@@ -9,7 +9,7 @@
 start() {
        # Mount local filesystems in /etc/fstab.
        ebegin "Mounting local filesystems"
-       mount -at noproc,noshm,no${NET_FS_LIST// /,no} -O no_netdev >/dev/null
+       mount -at noproc,noshm${NET_FS_LIST:+,no}${NET_FS_LIST// /,no} -O no_netdev >/dev/null
        eend $? "Some local filesystem failed to mount"
 
        # Make sure we insert usbcore if its a module

#

[Comment 1 SpanKY 2006-05-10 20:24:38 UTC]

i dont see how it could be empty

[Comment 2 Mark Dominik Bürkle 2006-05-12 10:57:06 UTC]

Well, NET_FS_LIST can only be empty by accident. :-/
Well - only a feature request, not really a bug, no need to really act upon it. :-)

[Comment 3 Roy Marples (RETIRED) 2006-06-05 06:42:44 UTC]

I see no harm in the patch, so I've added it to our SVN repo.

Will be in baselayout-1.12.1

[Comment 4 Roy Marples (RETIRED) 2006-06-05 07:37:32 UTC]

Fixed in baselayout-1.12.1

[Comment 5 Mark Dominik Bürkle 2006-10-11 10:38:33 UTC]

Thanks for fixing it.

Have seen that a long time ago on ~x86, iirc. :-)

Close/Fixed so it may be purged.