Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 132718 - aspell-dict.eclass sets KEYWORDS
Summary: aspell-dict.eclass sets KEYWORDS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High critical (vote)
Assignee: Gentoo Quality Assurance Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-08 13:46 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-11-30 17:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2006-05-08 13:46:31 UTC
As per summary, aspell-dict.eclass sets KEYWORDS in the eclass instead of having it in ebuilds:

if [ x${ASPOSTFIX} = x6 ] ; then
        RDEPEND=">=app-text/aspell-0.60"
        DEPEND="${RDEPEND}"
        KEYWORDS="~x86 ~ppc ~sparc ~amd64 ~x86-fbsd"
else
        RDEPEND=">=app-text/aspell-0.50"
        DEPEND="${RDEPEND}"
        KEYWORDS="x86 ppc sparc mips alpha arm hppa amd64 ia64 ppc64"
fi
Comment 1 Mark Loeser (RETIRED) gentoo-dev 2006-05-14 15:24:52 UTC
Pretty uncool to do, can you please move keywords to the packages themselves.
Comment 2 Mark Loeser (RETIRED) gentoo-dev 2006-05-14 15:33:21 UTC
Also, all of your new ebuilds have been pushed straight to stable as far as I can tell.  (look at aspell-it for an example)
Comment 3 Anders Rune Jensen (RETIRED) gentoo-dev 2006-05-15 08:43:20 UTC
The aspell-it was a bug in the ebuild that has been fixed.

Having all aspell dicts go straight to stable has always been the case. The only thing that has changed is that since aspell-0.6 is not stable we need to mark dicts which only compile with that version as unstable on the same archs that aspell is marked unstable on to be symmetric with the way it has been done for aspell-0.5.

The rationale for having dicts go straight to stable is that they are so simple that well they shouldn't really break if they have been compile tested. Anyway ispell dicts are individually marked unstable / stable so this is a bit strange.

Anyway this is the way it has always been. I have only been keeping the aspell packages updated since no one else wanted to? I'm open to changing these policies to something more sane.
Comment 4 Mark Loeser (RETIRED) gentoo-dev 2006-05-15 10:16:52 UTC
(In reply to comment #3)
> Anyway this is the way it has always been. I have only been keeping the aspell
> packages updated since no one else wanted to? I'm open to changing these
> policies to something more sane.

The sane way (imho) would be to keyword each package like we do everywhere else in the tree.  I know for x86 I do not want any package going straight to stable, no matter how simple it is.  Also, setting all of this in the eclass gives you no fine-grained control over how packages are keyworded.
Comment 5 Kevin F. Quinn (RETIRED) gentoo-dev 2006-11-30 17:55:32 UTC
KEYWORDS moved to ebuilds, removed from eclass.