Bug 132549 – sys-apps/baselayout-1.12.0_pre19-r2 : typo br2684ctl.sh module

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alin Năstac (RETIRED) 2006-05-07 04:44:13 UTC]

The module contains a mistake. Patch will follow.

[Comment 1 Alin Năstac (RETIRED) 2006-05-07 04:46:02 UTC]

Created attachment 86346 [details, diff]
fix config validation

[Comment 2 Roy Marples (RETIRED) 2006-05-07 09:43:31 UTC]

Fixed in our svn repo, thanks for the patch.

[Comment 3 Alin Năstac (RETIRED) 2006-05-07 13:52:10 UTC]

there are another 2 mistakes in post_stop function :
 1) itype should be replaced with interface_type
 2) for some reason the following line always returns 0 :
       [[ -e /var/run/br2864ctl-${iface}.pid ]] || return 0

[Comment 4 Alin Năstac (RETIRED) 2006-05-07 13:55:18 UTC]

ah, I forgot the most important change of all.
the -c parameter _must_ be first, otherwise it will not work! therefore, you should also check if br2684_${iface} don't contains -c.

[Comment 5 Roy Marples (RETIRED) 2006-05-08 02:08:47 UTC]

Requested changes are now in our svn repo

[Comment 6 Alin Năstac (RETIRED) 2006-05-08 10:54:35 UTC]

yet another typo in br2684ctlsh : s/interface_itype/interface_type/

since -c needs to be the first parameter, I would say -e should be placed before -a. 
net.example should propose a br2684ctl_nas0="-e 0 -a 0.38".  

[Comment 7 Roy Marples (RETIRED) 2006-05-08 11:37:24 UTC]

Requested changes are now in our svn repo

[Comment 8 Alin Năstac (RETIRED) 2006-05-08 21:57:55 UTC]

I've managed to test the HEAD revision of the br2684ctl.sh module.
It worked flawlessly. 

[Comment 9 Roy Marples (RETIRED) 2006-05-23 06:30:35 UTC]

Fixed in baselayout-1.12.0

[Comment 10 Roy Marples (RETIRED) 2006-05-23 06:30:57 UTC]

Whoops

[Comment 11 Roy Marples (RETIRED) 2006-05-23 06:31:19 UTC]

.