Bug 132450 – dev-util/wiggle misplaced files, XC failure and a couple of other little p things

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description James Rowe 2006-05-06 06:55:40 UTC]

`p help' attempts to process the non-existent /usr/bin/p.help file, the
attached patch fixes that.  The wiggle-p_bad_help_ref.patch changes the
build to install p.help in /usr/share/wiggle, and fixes the reference in the
script.

  The wiggle-no_default_signoff.patch stop p from adding Neil Brown's
sign-off line to *every* patch it sees.  The patch just removes the chunk
that tests, and adds, the sign-off to the file.  Caveat:  The method used in
the patch depends on a GNU extension to sed, but GNU sed is required for all
Gentoo systems no?

  The wiggle-p_fix_head_tail.patch uses fixheadtails.eclass to change the
calls to head and tail in the p script.  I realise the current coreutils no
longer require the change, but I spotted it whilst poking around and I'm not
sure if it is coming back in a later release.

  The build doesn't respect a user's CC values, which makes cross
compilation fail.  The attached wiggle-use_user_cc.patch fixes this.

  Now that the build is using the correct compiler...

  The default make targets tries to run the test suite, which ends up being
run twice if FEATURES=maketest is set.  More importantly, to me at least,
builds without maketest set fail completely if wiggle has been cross
compiled.

  The attached patch(wiggle-dont_run_test_in_compile.patch) fixes this by
only calling make on the wiggle target.

Thanks


James

[Comment 1 Jakub Moc (RETIRED) 2006-05-06 07:00:56 UTC]

*** Bug 132451 has been marked as a duplicate of this bug. ***

[Comment 2 Jakub Moc (RETIRED) 2006-05-06 07:01:15 UTC]

*** Bug 132452 has been marked as a duplicate of this bug. ***

[Comment 3 James Rowe 2006-05-06 07:04:11 UTC]

Created attachment 86271 [details, diff]
wiggle-p_bad_help_ref.patch

[Comment 4 James Rowe 2006-05-06 07:04:41 UTC]

Created attachment 86272 [details, diff]
wiggle-no_default_signoff.patch

[Comment 5 James Rowe 2006-05-06 07:05:14 UTC]

Created attachment 86273 [details, diff]
wiggle-p_fix_head_tail.patch

[Comment 6 James Rowe 2006-05-06 07:05:41 UTC]

Created attachment 86274 [details, diff]
wiggle-use_user_cc.patch

[Comment 7 James Rowe 2006-05-06 07:06:06 UTC]

Created attachment 86275 [details, diff]
wiggle-dont_run_test_in_compile.patch

[Comment 8 Robin Johnson 2006-05-13 01:18:13 UTC]

Thanks, in cvs now.