Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 132383 - Add git.eclass to portage
Summary: Add git.eclass to portage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Donnie Berkholz (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-05-05 14:07 UTC by Avuton Olrich
Modified: 2006-09-11 01:50 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
git.eclass (git.eclass,4.90 KB, text/plain)
2006-05-05 14:08 UTC, Avuton Olrich
Details
git.eclass (git.eclass,6.09 KB, text/plain)
2006-06-11 04:42 UTC, Fernando J. Pereda (RETIRED)
Details
git.eclass (git.eclass,6.29 KB, text/plain)
2006-06-16 10:28 UTC, Fernando J. Pereda (RETIRED)
Details
git.eclass (git.eclass,6.48 KB, text/plain)
2006-09-07 11:04 UTC, Fernando J. Pereda (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Avuton Olrich 2006-05-05 14:07:21 UTC
Here's a git.eclass, it'd be great to see this in portage. This uses and depends on cogito, and I could expand the cogito stuff out into the ebuild if requested. I've been using it for a couple of months now, and it works well for my purposes.
Comment 1 Avuton Olrich 2006-05-05 14:08:10 UTC
Created attachment 86224 [details]
git.eclass
Comment 2 Alec Warner (RETIRED) archtester gentoo-dev Security 2006-05-29 22:42:21 UTC
Donnie, you mentioned you had one on the gentoo-dev ML and I think ferdy was working with it a bit.

Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2006-05-29 23:04:39 UTC
Yep, I do have one. I've been sort of waiting for somebody who actually has a use for it in the portage tree before adding it, but I guess that sys-kernel/git-sources already could use it.
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-06-11 03:24:38 UTC
Donnie, I'd appreciate it in the tree so I can use it for testing some upstream userspace stuff.
Comment 5 Fernando J. Pereda (RETIRED) gentoo-dev 2006-06-11 04:40:47 UTC
Please try the attached git.eclass and report issues.

I still think we should repack and even prune the repositories every now in a while, more or less the same a user would do it if he tracked the git repo manually. So I'd appreciate comments and ideas.

- ferdy
Comment 6 Fernando J. Pereda (RETIRED) gentoo-dev 2006-06-11 04:42:27 UTC
Created attachment 88895 [details]
git.eclass

This version gets some fixes from spyderous and uses the new remote config scheme (thus depending on >=dev-util/git-1.4.0).
Comment 7 Avuton Olrich 2006-06-11 12:03:43 UTC
Perfect, that was a drop-in place replacement for my old cogito/git eclass, and works perfectly with my overlay. Thanks.
Comment 8 Hanno Böck gentoo-dev 2006-06-15 13:49:54 UTC
Would it be possible to change the eclass so it shows which files were changed on update? (like in the cvs.eclass)
Comment 9 Donnie Berkholz (RETIRED) gentoo-dev 2006-06-15 15:34:07 UTC
If you change `git-fetch -f -n -u` to `git-pull -f --no-tags -u` does that do it? I think it's the merge that shows changes, not the fetch.
Comment 10 Fernando J. Pereda (RETIRED) gentoo-dev 2006-06-16 10:27:18 UTC
Actually you can do it using 'git diffstat' (which is called by 'merge' which is called by 'pull' :P).

Please try the attached version and see if it suits your needs.

- ferdy
Comment 11 Fernando J. Pereda (RETIRED) gentoo-dev 2006-06-16 10:28:19 UTC
Created attachment 89324 [details]
git.eclass

This version shows a diffstat when doing updates.
Comment 12 Donnie Berkholz (RETIRED) gentoo-dev 2006-06-18 14:56:14 UTC
For anyone using my overlay for this, I've merged in the latest changes.
Comment 13 Hanno Böck gentoo-dev 2006-07-14 12:57:59 UTC
Suggestion: Change EGIT_PATCHES to PATCHES, because cvs and other eclasses use that as well, makes things more unified.
Comment 14 Donnie Berkholz (RETIRED) gentoo-dev 2006-07-14 13:13:19 UTC
subversion.eclass uses ESVN_PATCHES and horde.eclass uses EHORDE_PATCHES, there's precedent either way.
Comment 15 Fernando J. Pereda (RETIRED) gentoo-dev 2006-09-07 11:04:01 UTC
Created attachment 96300 [details]
git.eclass

This version should be ready for inclusion. Adds protocol URI check from Donnie's version and a couple of misc fixes / typos.

- ferdy
Comment 16 Donnie Berkholz (RETIRED) gentoo-dev 2006-09-07 11:08:03 UTC
Looks good to me. Could you post to -dev one last time? Then we'll commit.
Comment 17 Fernando J. Pereda (RETIRED) gentoo-dev 2006-09-11 01:50:21 UTC
This is in the tree now. Thanks for all the comments / fixes / feedback / ...

- ferdy