I'd like to see app-text/diction version 1.07 stabilised on all archs. Thanks, James
Seemant, I'm personally very happy with the 1.07 release on x86. I haven't used that release on any other arch :( I realise this keywording could look a little quick, but I have been using this release for a long long time before I/we've taken it. Thanks, James
arch teams, please stabilise 1.07 when you get a chance
i've done some testing on x86 with diction-1.0.7. to do that i've fooled around a bit with 'style' and 'diction'. my results: basically, diction-1.0.7 seems to be ok. however, there are some flaws (that may also exist for the current stable version (not tested)): 1.) 'style' does not check commandline arguments very severly: style -L bar.txt causes style to read from stdin, and not to print an error message. 2.) diction seems to have some problems with german umlauts: $ diction -L de test.txt ... [welcher -> Benutze "der", falls eine Einschr�nkung folgt.] ... Portage 2.0.54-r2 (default-linux/x86/2006.0, gcc-3.4.6, glibc-2.3.6-r3, 2.6.16-gentoo-r7 i686) ================================================================= System uname: 2.6.16-gentoo-r7 i686 AMD Athlon(tm) XP 2400+ Gentoo Base System version 1.6.14 dev-lang/python: 2.3.5-r2, 2.4.2 dev-python/pycrypto: [Not Present] dev-util/ccache: [Not Present] dev-util/confcache: [Not Present] sys-apps/sandbox: 1.2.17 sys-devel/autoconf: 2.13, 2.59-r7 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r1 sys-devel/binutils: 2.16.1-r2 sys-devel/libtool: 1.5.22 virtual/os-headers: 2.6.11-r2 ACCEPT_KEYWORDS="x86" AUTOCLEAN="yes" CBUILD="i686-pc-linux-gnu" CFLAGS="-march=athlon-xp -O2 -pipe" CHOST="i686-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/kde/3.4/env /usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/lib/X11/xkb /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/" CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d" CXXFLAGS="-march=athlon-xp -O2 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="autoconfig collision-protect distlocks sandbox sfperms strict test" GENTOO_MIRRORS="http://gentoo.ynet.sk/pub " LANG="en_US.utf8" LC_ALL="en_US.utf8" LINGUAS="en de" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/local/portage" SYNC="rsync://192.168.0.1/gentoo-portage" USE="x86 3dnow 3dnowext X a52 aac aalib acpi alsa apm audiofile avi berkdb bitmap-fonts bonobo bzip2 cairo cdr cli crypt css cups curl dbus dri dts dvd dvdr dvdread eds emboss encode exif expat fam fbcon ffmpeg firefox flac foomaticdb fortran gd gdbm gif ginac glut gmp gnome gphoto2 gpm gstreamer gtk gtk2 gtkhtml guile hal icq idn imagemagick imlib ipv6 isdnlog java javascript jpeg jpeg2k junit lcms libg++ libwww mad matroska mikmod mime mmx mmxext mng motif mozsvg mp3 mpeg msn nautilus ncurses nls nptl nsplugin nvidia offensive ogg oggvorbis openal opengl pam pcre pdflib perl plotutils png posix pppd python quicktime readline real reflection ruby sdl session slang sockets speex spell spl sqlite sqlite3 sse ssl subtitles svg svga tcltk tcpd tetex theora tiff truetype truetype-fonts type1-fonts udev unicode usb vcd vorbis win32codecs wma xine xml xml2 xmms xorg xv xvid zlib video_cards_nvidia linguas_en linguas_de userland_GNU kernel_linux elibc_glibc" Unset: CTARGET, INSTALL_MASK, LDFLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTAGE_RSYNC_OPTS
Matthias, > 1.) 'style' does not check commandline arguments very severly: > style -L bar.txt causes style to read from stdin, and not to print an > error message. This applies to the current stable, both unstable and the unpackaged pre-release versions. I'm going to test a patch I've just hacked up to fix this, and then push it upstream. The cause of the bug is style just uses English unless your -L option begins with "de" in which case it switches to German, it should definitely be more strict. > 2.) diction seems to have some problems with german umlauts: > $ diction -L de test.txt > ... [welcher -> Benutze "der", falls eine Einschr�nkung folgt.] I can't replicate this locally. Could you see what happens when you run "grep welcher /usr/share/diction/de" please? Whatever I try the output is displayed correctly here. And if you could attach a small file that exhibits the problem that would be great. Thanks for the report
Created attachment 88178 [details] testcase for german umlauts $ diction -L de test.txt test.txt:1: Dieser Text soll verdeutlichen, da
Created attachment 88178 [details] testcase for german umlauts $ diction -L de test.txt test.txt:1: Dieser Text soll verdeutlichen, daß 'dict' unter Umständen Probleme mit Deutschen Umlauten wie ä, ü, ö hat, [so -> "So" ist oft so �berfl�ssig.] wie ich das in meinem Kommentar zu bug #131637 bereits angemerkt habe. 1 phrase in 1 sentence found. $ grep welcher /usr/share/diction/de welcher Benutze "der", falls eine Einschr�nkung folgt. Note that i've unicode in my useflags and at least german umlauts are displayed correctly with most programs.
Okay, I still can't replicate this on any system I have access to with your testcase or my admittedly small German email corpus. > $ diction -L de test.txt > test.txt:1: Dieser Text soll verdeutlichen, daß 'dict' unter Umständen > Probleme mit Deutschen Umlauten wie ä, ü, ö hat, [so -> "So" ist oft so > �berfl�ssig.] wie ich das in meinem Kommentar zu bug #131637 > bereits > angemerkt habe. > > 1 phrase in 1 sentence found. The output suggests the bug is only related to diction's datafile though, as the accented characters are presented correctly in the surrounding text. I've attached a small patch for the ebuild which I'd be very greatful if you could test, it simply converts the datafile to UTF-8. > $ grep welcher /usr/share/diction/de > welcher Benutze "der", falls eine Einschr�nkung folgt. That backs up the opinion it is just a problem with the datafile. > Note that i've unicode in my useflags and at least german umlauts are displayed > correctly with most programs. The datafile is actually in a legacy ISO-8859 encoding, and that is about the only reason I can think of that this could be causing a problem although really I don't think it should be an issue if your environment is set up for German. You say "with most programs," so I'm guessing you've seen this sort of broken output before. Any pointers to other apps that exhibit this would be helpful, unless the attached patch fixes the problem in which case I should have enough to go on. Once again, thanks. Your testing and patience is really appreciated.
Okay, I still can't replicate this on any system I have access to with your testcase or my admittedly small German email corpus. > $ diction -L de test.txt > test.txt:1: Dieser Text soll verdeutlichen, daà 'dict' unter Umständen > Probleme mit Deutschen Umlauten wie ä, ü, ö hat, [so -> "So" ist oft so > �berfl�ssig.] wie ich das in meinem Kommentar zu bug #131637 > bereits > angemerkt habe. > > 1 phrase in 1 sentence found. The output suggests the bug is only related to diction's datafile though, as the accented characters are presented correctly in the surrounding text. I've attached a small patch for the ebuild which I'd be very greatful if you could test, it simply converts the datafile to UTF-8. > $ grep welcher /usr/share/diction/de > welcher Benutze "der", falls eine Einschr�nkung folgt. That backs up the opinion it is just a problem with the datafile. > Note that i've unicode in my useflags and at least german umlauts are displayed > correctly with most programs. The datafile is actually in a legacy ISO-8859 encoding, and that is about the only reason I can think of that this could be causing a problem although really I don't think it should be an issue if your environment is set up for German. You say "with most programs," so I'm guessing you've seen this sort of broken output before. Any pointers to other apps that exhibit this would be helpful, unless the attached patch fixes the problem in which case I should have enough to go on. Once again, thanks. Your testing and patience is really appreciated.
Created attachment 88234 [details, diff] diction-conv_encode.patch
unfortunately i have no time right now; i'll test your patch in about 12 hours ...
Thats okay, and please note I don't propose the patch as a correct fix. I just want to make sure it is an encoding issue that is causing the problem. Thanks again.
congratulations; your patch fixes the problems with german umlauts for me.
Thanks again Matthias, much appreciated. I'm temporarily closing this bug pending the resolution of the problems Matthias raised.
.
reopening for 1.09-r1
diction-1.07-r1 stable on sparc. English text seems fine, and the attached testcase for umlauts works as expected.
x86 done
ppc stable
mips and mac-osx teams, please do the stabling thing
actually, mips and osx, you guys don't *have* to stable it, but you may wanna look into it.
ppc-macos stable, sorry for the delay.
