Bug 130962 – [PATCH] Allow protoize to build on FreeBSD

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Diego Elio Pettenò (RETIRED) 2006-04-23 05:43:31 UTC]

And here we are with the patch to fix GCC on Gentoo/FreeBSD to build protoize.

This should be fine for other operating systems, too. Basically it relies on GCC/libc to define the type rather than defining it on its own (on FreeBSD it's char* rather than int).

I can't find anything in GCC sources that relies on the type being defined in that place.

Now, please apply this patch and get rid of the ugly hack on toolchain.eclass. :)

Thanks,
Diego

[Comment 1 Diego Elio Pettenò (RETIRED) 2006-04-23 05:44:00 UTC]

Created attachment 85270 [details, diff]
gcc-3.4.6-protoize-fbsd.patch

[Comment 2 SpanKY 2006-04-23 14:15:48 UTC]

gcc trunk still does this so you should get upstream fixed first :p

maybe update gcc/configure.in to check for __gnuc_va_list type by including stdio.h

[Comment 3 SpanKY 2006-04-24 00:11:10 UTC]

on second thought, try this patch:
                # Build protoize
                emake -C gcc \
+                       GCC_FOR_TARGET="$(XGCC)" \
                        LDFLAGS="${LDFLAGS}" \

[Comment 4 Diego Elio Pettenò (RETIRED) 2006-04-24 02:53:39 UTC]

Doesn't help.

Where should I submit the upstream patch?

[Comment 5 Diego Elio Pettenò (RETIRED) 2006-04-26 10:28:42 UTC]

The patch Mike gave me today (http://dev.gentoo.org/~vapier/patches/toolchain.eclass.protoize.patch ) works as a charm.

[Comment 6 SpanKY 2006-04-28 19:21:46 UTC]

all set now

[Comment 7 SpanKY 2006-09-05 19:11:58 UTC]

re-opening since you just added back in hacks instead of looking into the real problem

[Comment 8 Diego Elio Pettenò (RETIRED) 2006-09-06 04:20:21 UTC]

Really, I'd rather not have protoize on g/fbsd instead of having a non-building GCC.

[Comment 9 Mark Loeser (RETIRED) 2008-07-06 00:28:53 UTC]

They are talking about deprecating protoize upstream.  Its a pretty useless tool anyway, and I can't even remember why we added it at this point.