Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 130762 - make adplug-1.5.1 work properly with libbinio 1.4+ (needed for all apps that use adplug as a library)
Summary: make adplug-1.5.1 work properly with libbinio 1.4+ (needed for all apps that...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Michal Januszewski (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 133239
  Show dependency tree
 
Reported: 2006-04-21 12:25 UTC by Stian Skjelstad
Modified: 2006-05-14 05:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
adplug-1.5.1-libbinio.patch (adplug-1.5.1-libbinio.patch,2.56 KB, patch)
2006-04-21 12:26 UTC, Stian Skjelstad
Details | Diff
adplug-1.5.1-r2.ebuild (adplug-1.5.1-r2.ebuild,705 bytes, text/plain)
2006-04-21 12:26 UTC, Stian Skjelstad
Details
adplug-1.5.1-r2.ebuild (adplug-1.5.1-r2.ebuild,705 bytes, text/plain)
2006-05-13 14:39 UTC, Stian Skjelstad
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stian Skjelstad 2006-04-21 12:25:02 UTC
Since newer versions of libbinio has been pushed out, adplug needs proper updates (the -r1 one is masked, and is not proper anyway)
Comment 1 Stian Skjelstad 2006-04-21 12:26:14 UTC
Created attachment 85136 [details, diff]
adplug-1.5.1-libbinio.patch
Comment 2 Stian Skjelstad 2006-04-21 12:26:43 UTC
Created attachment 85137 [details]
adplug-1.5.1-r2.ebuild
Comment 3 Thomas Petersen 2006-04-21 15:54:43 UTC
According to
http://sourceforge.net/tracker/index.php?func=detail&aid=1294720&group_id=28079&atid=392364
the problem is fixed (somewhat) in cvs of adplug by adding a check for the right CFLAGS and LDFLAGS for libbinio by using pkg-config in the configure script.
That however doesn't fix all programs that make use of adplug. They also have to check for the right CFLAGS for libbinio.
A nice solution for this could be that adplug installs a adplug.pc file for pkg-config which would include the CFLAGS for libbinio... but that would be up to the adplug devs to decide.
Comment 4 Stian Skjelstad 2006-04-22 02:38:59 UTC
If they later descide to make a .pc file for their project or not, doesn't change the fact that all programs that make use of adplug today in gentoo fails to compile. So atleast I find it needed to apply this patch. Atleast as long as they don't use pkg-config as of today, and projects that take use of adplug shouldn't need to add an unknown CXXFLAGS because of this.
Comment 5 Stian Skjelstad 2006-05-13 14:39:16 UTC
Created attachment 86719 [details]
adplug-1.5.1-r2.ebuild

Depend on libbinio version 1.4+
Comment 6 Michal Januszewski (RETIRED) gentoo-dev 2006-05-14 05:33:06 UTC
Thanks, I've just added this new ebuild to CVS. I'll try to get it to stable on all arches ASAP.