Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 130494 - patch for mplayer ebuild to build only $LINGUAS html documentation if possible
Summary: patch for mplayer ebuild to build only $LINGUAS html documentation if possible
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Low enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
: 172314 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-04-19 10:15 UTC by Botykai Zsolt
Modified: 2009-08-03 22:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayer*ebuild patch to install only LINGUAS html docs (mplayerebuild.patch,976 bytes, patch)
2006-04-19 10:17 UTC, Botykai Zsolt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Botykai Zsolt 2006-04-19 10:15:57 UTC
Just recognised, that installing mplayer build some unwanted html documentation (e.g. polish, russian for me).
So I created a new ebuild to install those that appears in $LINGUAS (if possible). It just works for me.
Patch will be attached.

# emerge --info
Portage 2.1_pre7-r5 (default-linux/x86/2005.1, gcc-3.4.6, glibc-2.4-r1, 2.6.16-gentoo-r2 i686)
=================================================================
System uname: 2.6.16-gentoo-r2 i686 Intel(R) Celeron(R) CPU 2.40GHz
Gentoo Base System version 1.12.0_pre17
dev-lang/python:     2.3.5-r2, 2.4.2-r1
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r2
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r3
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=pentium4 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/kde/3/share/config /usr/share/X11/xkb /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/eselect/compiler /etc/gconf /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -march=pentium4 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig distlocks metadata-transfer noinfo notitles sandbox sfperms strict"
GENTOO_MIRRORS="http://gentoo.inf.elte.hu/ http://gentoo.inode.at/ http://distfiles.gentoo.org http://www.ibiblio.org/pub/Linux/distributions/gentoo"
LANG="hu_HU"
LC_ALL="hu_HU"
LINGUAS="hu en"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="x86 X alsa apm avi bash-completion berkdb bitmap-fonts bzip2 crypt cups curl dbus dri dvd eds emboss encode examples exif flac foomaticdb fortran ftp gdbm gif gphoto2 gpm gstreamer gtk gtk2 hal imagemagick imlib isdnlog jabber javascript jpeg jpeg2k kde kdexdeltas libg++ libwww mad maildir mbox mikmod mime mng motif mp3 mpeg ncurses nls nptl offensive ogg oggvorbis opengl oss pam pcre pdf pdflib perl pic plotutils png pppd python qt quicktime readline ruby samba sdl sockets spell ssl svg tcpd tidy tiff truetype truetype-fonts type1-fonts unicode usb vorbis win32codecs xface xml2 xv zlib elibc_glibc input_devices_keyboard input_devices_mouse kernel_linux linguas_hu linguas_en userland_GNU video_cards_fbdev video_cards_sis video_cards_vesa"
Unset:  ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS
Comment 1 Botykai Zsolt 2006-04-19 10:17:12 UTC
Created attachment 84971 [details, diff]
mplayer*ebuild patch to install only LINGUAS html docs
Comment 2 Luca Barbato gentoo-dev 2006-04-19 14:40:30 UTC
I'll look at the issue later, thanks for the proposed solution
Comment 3 kalium 2006-08-24 05:02:36 UTC
Docs generation takes quite a while and cannot be cached like c/c++. Would be nice to have that feature added to the ebuilds.
Comment 4 Steve Dibb (RETIRED) gentoo-dev 2007-03-26 18:27:22 UTC
*** Bug 172314 has been marked as a duplicate of this bug. ***
Comment 5 Martin von Gagern 2007-03-26 19:25:23 UTC
(In reply to comment #4)
> *** Bug 172314 has been marked as a duplicate of this bug. ***

My patch from that bug has some advantages over the one here:
1. only one loop, not two
2. does not rely on internal structure of Makefile, but rather on directories
3. does not modify Makefile, but rather uses provided make targets

Especially 2 & 3 together can be a bad combination if you were to run the compile phase multiple times.

The fallback for the case of no matching language is arguable. The patch here builds all languages, while my patch builds none and rather issues a warning. A third alternative would be to only build english in that case.
I'm not talking about the case when LINGUAS is not set in the first place, as in this scenario both patches would build all available languages, as far as I can tell.

(In reply to bug #172314 comment #2)
> As far as the linguas USE flags, it works fine with and without the USE flags,
> so no real hurry to clean it up.

Nevertheless it would be interesting if you want it cleaned up eventually. If you wanted that untouched, I could adapt my patch to only affect the doc generation in src_compile, and leave all else alone. Right now it integrates somewhat with other LINGUAS magic, such that I would prefer not to split them apart if you were going to apply those parts as well later on.

> Not going to install less documentation, just because it seems irrelevant.

There is imo a fuzzy line between irrelevant documentation and redundant documentation, especially concerning the man pages. For the others I can understand your point, and it would be easy enough to simply remove the last hunk from my patch to drop this matter.

Though perhaps using dohtml and dodoc and so on would be better, concerning compression and directory structure. I'm not sure.
Comment 6 Steve Dibb (RETIRED) gentoo-dev 2009-08-03 20:02:51 UTC
This should be fixed in 1.0_rc2_p20090731 since mplayer has an option to pass which languages to build docs for, by default, using LINGUAS instead of all.