Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 130407 - hddtemp has byte-swapped drive model name
Summary: hddtemp has byte-swapped drive model name
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC64 Linux
: High major (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-18 14:14 UTC by Robin Johnson
Modified: 2006-05-26 02:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
hddtemp-0.3_beta15-byteswap.patch (hddtemp-0.3_beta15-byteswap.patch,1.01 KB, patch)
2006-05-21 23:37 UTC, Robin Johnson 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-04-18 14:14:41 UTC 
On my new G5, using a 64-bit kernel and 32-bit userland, the model name as output by hddtemp is byte-swapped for my SATA drive. I don't have any IDE/SCSI devices in here, so I can't check if those are swapped as well.

output:
# hddtemp /dev/sda
(standard warning)
/dev/sda: DW CDW5200SJ4-M1BV 1: 44 C or  F.

The drive model as provided by smartctl:
"WDC WD2500JS-41MVB1 "
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-05-14 03:46:50 UTC 
I sent a patch to upstream, waiting for a response on it.
Comment 2 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-05-21 23:37:56 UTC 
Created attachment 87233 [details, diff]
hddtemp-0.3_beta15-byteswap.patch

This is the patch I submitted to upstream, against their latest beta.
It works perfectly for x86 and PPC (my only machines with SATA).

I haven't had a response from upstream yet, so if there are no objections, I'd like to bump hddtemp to beta15 and have this patch with it.
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2006-05-26 02:08:08 UTC 
I haven't had any response from upstream at all.
I've commited this to the tree now, along with a patch to hddtemp.db that I cooked up for fully supporting Maxtor DiamondMax 10 drives (of which I have a lot).