Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 130406 - ebuild.sh, unpack *.tar.bz not handled
Summary: ebuild.sh, unpack *.tar.bz not handled
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: High normal
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2006-04-18 14:02 UTC by Stefan Schweizer (RETIRED)
Modified: 2006-04-21 14:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schweizer (RETIRED) gentoo-dev 2006-04-18 14:02:47 UTC
Hi,

in ebuild.sh:

[..]
case "${x##*.}" in
[..]
  bz2)
    if [ "${y}" == "tar" ]; then
[..]

It should read "bz2|bz)" to also include tar.bz files.

The offending line is 387 (portage-2.1_pre9-r1)
Comment 1 SpanKY gentoo-dev 2006-04-18 15:29:11 UTC
bz is invalid imho
Comment 2 Stefan Schweizer (RETIRED) gentoo-dev 2006-04-18 15:43:52 UTC
I get 212.000 on google for tar.bz

Compared to the 6.650.000 tar.bz2 results that makes 3.19%, seems to be widely used.

But, anyway, I would like to use it in real-world ebuilds like:
http://genstef.homelinux.org/local/kde-misc/kbfx/kbfx-0.4.9.1.ebuild

Please add this simple fix, it harms no one.
Comment 3 SpanKY gentoo-dev 2006-04-18 21:52:55 UTC
just because people do it doesnt make it correct :P
Comment 4 Steffen Jobbagy-Felso 2006-04-21 01:32:22 UTC
File endings as such are an offensive concept (handy though, I'll admit that), but we got to live with what we get ;)
On the topic: Looking at http://www.gentoo.org/cgi-bin/viewcvs.cgi/*checkout*/sys-apps/portage/ChangeLog apparently the fix has already been added to Portage 2.1_pre9-r2 though I can't confirm that from my local tree, that sync a few minutes ago didn't grab pre9 yet :(
Whether using .tar.bz is correct or not is IMO not important, people DO use it, and I for one can't think of anything that could have this ending other than a bzip2 archive. So I think the patch should stay.
Comment 5 Stefan Schweizer (RETIRED) gentoo-dev 2006-04-21 01:42:04 UTC
worksforme :)

now we just need to get it into the stable portage so that ebuilds can start using it.
Comment 6 Brian Harring (RETIRED) gentoo-dev 2006-04-21 01:46:14 UTC
(In reply to comment #5)
> worksforme :)
> 
> now we just need to get it into the stable portage so that ebuilds can start
> using it.
with appropriate dep of course...

Comment 7 Zac Medico gentoo-dev 2006-04-21 14:55:14 UTC
Released in 2.1_pre9-r2.