Bug 130402 – media-sound/alsa-driver-1.0.11_rc5 doesn't compile on ~ppc

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alberto Zennaro 2006-04-18 13:37:57 UTC]

Emerge fails with a powermac card on ~ppc.
Attached you find the patch from upstream.

[Comment 1 Alberto Zennaro 2006-04-18 13:38:36 UTC]

Created attachment 84919 [details, diff]
Fix powermac error

[Comment 2 Diego Elio Pettenò (RETIRED) 2006-04-18 13:44:41 UTC]

Thanks for the patch, applied to 1.0.11_rc5.

[Comment 3 Alberto Zennaro 2006-04-21 16:36:04 UTC]

I'm reopening it because the 1.0.11 final has the same problem.

[Comment 4 Igor Rafienko 2006-04-22 07:23:43 UTC]

Hmm... 

It looks like the unconditional patching with powermac.patch causes a bit of a problem on amd64 (or, perhaps, not only amd64):

# emerge -Dvp alsa-driver
[ebuild   R   ] media-sound/alsa-driver-1.0.11  USE="doc oss -debug" 0 kB 
# emerge -Dv alsa-driver
(...)
 * Failed Patch: alsa-driver-1.0.11-powermac.patch !
 *(/usr/portage/media-sound/alsa-driver/files/alsa-driver-1.0.11-powermac.patch)
 * 
 * Include in your bugreport the contents of:
 * 
 /var/tmp/portage/alsa-driver-1.0.11/temp/alsa-driver-1.0.11-powermac.patch-16038.out

The file says that there is no file to patch. When I look into the powermac.patch, I see that it patches alsa-driver-1.0.11rc5/ppc/../alsa-kernel/ppc/pmac.c

The file is there (at least alsa-kernel/ppc/pmac.c part is correct), but perhaps the patching should be delayed to src_unpack? It seems to me that under pkg_setup (where the epatch is issued), portage stays in whichever directory emerge is being run. In such a case, naturally, all attempts of epatch would fail miserably, as the patch itself assumes that we are somewhere in the alsa-driver tree.

Any thoughts?

[Comment 5 Diego Elio Pettenò (RETIRED) 2006-04-22 07:33:55 UTC]

D'oh, thanks Igor, I actually overseen that, added it blindly :|

Fixed now :)