Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 130333 - games-arcade/funnyboat (new ebuild)
Summary: games-arcade/funnyboat (new ebuild)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Gentoo Games
URL: http://www.pyweek.org/e/Pekuja/
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2006-04-18 01:09 UTC by Cristiano Chiucchiolo
Modified: 2006-04-25 00:11 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
funnyboat-1.0.ebuild (funnyboat-1.0.ebuild,1.02 KB, text/plain)
2006-04-18 01:10 UTC, Cristiano Chiucchiolo
Details
funnyboat-1.1.ebuild (funnyboat-1.1.ebuild,1.00 KB, text/plain)
2006-04-23 10:05 UTC, Cristiano Chiucchiolo
Details
funnyboat-1.1.ebuild (funnyboat-1.1.ebuild,994 bytes, text/plain)
2006-04-24 12:58 UTC, Cristiano Chiucchiolo
Details
funnyboat-1.1.ebuild (funnyboat-1.1.ebuild,815 bytes, text/plain)
2006-04-24 14:19 UTC, Alexandru Toma
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cristiano Chiucchiolo 2006-04-18 01:09:28 UTC
I wrote an ebuild for this nice python game. Here it is.
Comment 1 Cristiano Chiucchiolo 2006-04-18 01:10:04 UTC
Created attachment 84880 [details]
funnyboat-1.0.ebuild
Comment 2 Cristiano Chiucchiolo 2006-04-23 10:05:57 UTC
Created attachment 85283 [details]
funnyboat-1.1.ebuild
Comment 3 Alexandru Toma 2006-04-23 10:41:50 UTC
http://www.pyweek.org/e/Pekuja/ doesn't exist... you should change the homepage to
http://funnyboat.sourceforge.net/

A few other issues IMO:
1) All those echos in src_unpack could be replaced with a call to games_make_wrapper in src_install.
2) You should fix the LICENSE. There are actually three different licenses, not just GPL-2: one for the source code, one for the music, and another one for the gfx and sound effects.
3) You shouldn't install the licenses. Just the readme, Changelog and other docs.
4) Pygame already depends on Python, so you can drop that from DEPEND. You could also drop numeric if it works with >=dev-python/numeric-22.0 which Pygame depends on.
5) You should rename RDEPEND to DEPEND since it's the same [1])

Just some advice from a fellow user ;)

[1] http://www.gentoo.org/proj/en/desktop/games/games-ebuild-howto.xml#doc_chap3_sect11
Comment 4 Cristiano Chiucchiolo 2006-04-24 12:58:21 UTC
Created attachment 85374 [details]
funnyboat-1.1.ebuild
Comment 5 Alexandru Toma 2006-04-24 14:19:59 UTC
Created attachment 85383 [details]
funnyboat-1.1.ebuild

My shot at an ebuild... based on the ebuild Cristiano submitted.

Marked x86 because I only tested it on x86. Also removed some dependencies and inherits since they are not needed.

The doicon, make_desktop_entry is not tested by me since I run FLuxbox.

Please also note that the LICENSE in the previous ebuilds is not correct. This ebuild has the correct licenses listed. Please also note that CCPL-Attribution-2.5 _is not_ currently in portage.
Comment 6 Mr. Bones. (RETIRED) gentoo-dev 2006-04-24 15:57:38 UTC
in portage.  thanks for the bug report and ebuild.
Comment 7 Alexandru Toma 2006-04-25 00:11:19 UTC
Mr. Bones, I have a few questions about the ebuild you comitted:
1) Why do you inherit eutils?
2) Why do you depend on dev-python/numeric if pygame already depends on it?
3) What's the advantage of using cat instead make_games_wrapper to create the wrapper script? You could get rid of src_unpack altogether.

Thank you.