130205 – gtkpod (-0.99.4) should RDEPEND on "mp3gain" or "aacgain"

Bug 130205 - gtkpod (-0.99.4) should RDEPEND on "mp3gain" or "aacgain"

Summary: gtkpod (-0.99.4) should RDEPEND on "mp3gain" or "aacgain"

Status:	RESOLVED WORKSFORME

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Olivier Crete (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2006-04-16 17:25 UTC by Axel Dyks
Modified:	2007-01-13 18:10 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Axel Dyks 2006-04-16 17:25:59 UTC

The "volume normalization" feature depends on "mp3gain"
or -- if aac support is needed which is quite likely --
on "aacgain".

For the only version (-1.5) of "aacgain" that is
available in portage is "~x86", RDEPEND on "aacgain"
should be "guarded" by IUSE "aac", I think.

  aac?  ( >= media-sound/aacgain )
  !aac? ( >= media-sound/mp3gain)

-- Axel

Comment 1 Axel Dyks 2006-04-16 20:33:19 UTC

I've just noticed that "gtkpod" isn't able to handle
the "replaygain" tags for mp4/aac files, though
"aacgain" seems to be able to handle/set them.

So, RDEPEND-ing on "accgain" does not make
any sense at the moment, while RDEPEND-ing
on "mp3gain" seems to be correct.

-- Axel

Comment 2 Olivier Crete (RETIRED) gentoo-dev

2006-04-17 13:24:46 UTC

well.. its not necessary for the proper operation of gtkpod, that's why I dont depend on it, I can even guess that very few people use it.. I could probably add a einfo() message about it.

Comment 3 Axel Dyks 2006-04-23 12:26:59 UTC

OK by me, i. e. do whatever seems to be appropriate
and close the bug.
I've filed it, because I thought that this runtime
dependency has been overlooked. :-)

-- Axel