Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 13017 - package "sys-apps/pcmcia-cs" file pcmcia.rc
Summary: package "sys-apps/pcmcia-cs" file pcmcia.rc
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Chad Huneycutt (RETIRED)
URL:
Whiteboard:
Keywords:
: 13677 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-01-01 09:07 UTC by gaplo
Modified: 2003-04-04 01:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gaplo 2003-01-01 09:07:08 UTC
Line 36
it should be:
 if [ -z 'fgrep "ds " /proc/modules' ] ; then

rather then
 if [ -z `fgrep "ds " /proc/modules` ] ; then

i.e. replace "'" with "`"
Comment 1 SpanKY gentoo-dev 2003-01-01 15:52:33 UTC
i dont see anything to change ...

root@rux0r files # grep /proc/modules pcmcia.rc 
        if [ -z `fgrep "ds " /proc/modules` ] ; then
        if [ -z `fgrep -q "ds " /proc/modules` ]; then
Comment 2 YAMAKURA Makoto 2003-01-06 18:48:37 UTC
I have another problem:

  $ fgrep "ds " /proc/modules
  ds                      6696   1 [cb_enabler]
  pcmcia_core            44096   0 [cb_enabler ds i82365]

This results syntax error near the if block. (It contains many brackets)
A favorable fix is:
  if grep -q "^ds " /proc/modules; then


Btw, second "if [ -z ...]" results always true because "fgrep -q" runs silently.
Comment 3 SpanKY gentoo-dev 2003-01-10 18:13:49 UTC
*** Bug 13677 has been marked as a duplicate of this bug. ***
Comment 4 Michael Cummings (RETIRED) gentoo-dev 2003-01-10 18:33:17 UTC
My only gripe is the error message - I only load one pcmcia device, my wireless
card, and that loads up fine.My line 36 looks right as well - is this a case of
too many arguments for a bash array? (thought that was hard to accomplish...)
Comment 5 Chad Huneycutt (RETIRED) gentoo-dev 2003-01-23 02:55:03 UTC
Okay, take a look at the new init script (either remerge pcmcia-cs or grab
/usr/portage/sys-apps/pcmcia-cs/files/pcmcia.rc).  I went a little overboard
with my pipeline, but it should work just fine.

Please test.
Comment 6 YAMAKURA Makoto 2003-01-23 17:43:36 UTC
It works fine for me. Thanks!
Comment 7 John Davis (zhen) (RETIRED) gentoo-dev 2003-04-04 01:21:24 UTC
db fix
Comment 8 John Davis (zhen) (RETIRED) gentoo-dev 2003-04-04 01:26:15 UTC
db fix