Bug 130098 – eselect env update fails if string "all:" is present in /etc/env.d/*

• Status: RESOLVED FIXED
• Product: Gentoo Hosted Projects

[Description Guenther Brunthaler 2006-04-15 13:44:21 UTC]

There seems to be a problem in the /etc/env.d/* files parser
used by "eselect env update":

Whenever the string "all:" is present in such an env-var snippet,
even if only as part of a comment, the following error message is displayed:

"Skipping non-text file <name of snippet>"

For example,

cat > /etc/env.d/99test <<EOF
# all:
EOF
eselect env update

yields

Skipping non-text file /etc/env.d/99test.
Regenerating /etc/ld.so.cache...

[Comment 1 Jakub Moc (RETIRED) 2006-04-15 17:10:16 UTC]

Please, don't restrict bugs without any reason.

[Comment 2 Patrick McLean 2006-06-08 13:24:57 UTC]

Created attachment 88718 [details, diff]
eselect-allow-file-makefile.patch

This works around this, but it will now accept makefiles as env.d files.

The cause of this problem seems to be that file detects any file with the string "all:" in it as a makefile. (at least it reports to be skipping, though I don't see the code that actually skips the file).

This patch makes it so eselect will use files that are detected as a makefile.

[Comment 3 Danny van Dyk (RETIRED) 2006-06-11 07:24:57 UTC]

Patrick: I used a slightly different patch to solve this problem.
What i didn't like in your patch was, that the whitelisting system wasn't
easily extendable.

Fix for this is InSVN.

[Comment 4 Danny van Dyk (RETIRED) 2006-07-03 12:47:42 UTC]

Fixed as of eselect-1.0.3