Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 129811 - merging sys-apps/hal fails if kernel sources aren't available
Summary: merging sys-apps/hal fails if kernel sources aren't available
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Doug Goldstein (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-13 07:23 UTC by Chris Gianelloni (RETIRED)
Modified: 2006-10-16 10:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
hal 0.5.5.1 patch (hal-0.5.5.1-dont_die_like_a_retard_when_we_cant_find_sources.patch,1001 bytes, patch)
2006-06-30 13:47 UTC, Chris Gianelloni (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gianelloni (RETIRED) gentoo-dev 2006-04-13 07:23:18 UTC
When building a LiveCD with USE=hal, the ebuild dies when it cannot find a configured kernel.  Kernel configuration is done in livecd-stage2, whereas packages are installed in livecd-stage1.  Honestly, I don't see why the package fails to build in any way.  The checks are somewhat worthless considering someone can change their kernel after the fact to be incompatible.  While I wouldn't mind seeing the checks go away completely, they should at least be downgraded to a warning since the package builds fine without these checks.

This will block the 2006.1 release.

Removing linux-info_pkg_setup and changing the notify_uevent stuff to be a warning only works perfectly.  The same thing needs to be done for the ACPI check, too.  Really, the kernel version check should probably be changed, too.
Comment 1 Steev Klimaszewski (RETIRED) gentoo-dev 2006-04-27 21:02:32 UTC
Please CC gentopia on hal bugs :)
Comment 2 Saleem Abdulrasool (RETIRED) gentoo-dev 2006-05-08 11:49:36 UTC
-r2 no longer dies on the failed checks.
Comment 3 Lars Weiler (RETIRED) gentoo-dev 2006-06-27 03:21:52 UTC
(In reply to comment #2)
> -r2 no longer dies on the failed checks.

It still fails.  The problem is is line 551 in linux-info.eclass:

  get_version || die "Unable to calculate Linux Kernel version"

I exchanged the die with ewarn (yes, ugly, but for testing only) and hal is still able to compile.

Please make sure, that hal could be compiled without a kernel installed.  Otherwise it's a showstopper for the 2006.1-release.
Comment 4 Chris Gianelloni (RETIRED) gentoo-dev 2006-06-30 13:25:51 UTC
Can we get this resolved?  This is blocking my snapshot, currently.
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2006-06-30 13:47:39 UTC
Created attachment 90561 [details, diff]
hal 0.5.5.1 patch

This patch applies to the current stable hal version.  To apply it to newer versions, it'll need to be adjusted slightly.

If this is not resolved by the time I take my snapshot, then this is the patch I'll be using for the official release media.  Quite simply, a non-kernel module should *never* die if it can't find the sources.
Comment 6 Lars Weiler (RETIRED) gentoo-dev 2006-09-13 14:21:39 UTC
We are in the time after release now and every catalyst-test-run fails on it.  It would be nice when not every self-made snapshot for a test needs to be patched.
Comment 7 Stefan Schweizer (RETIRED) gentoo-dev 2006-10-16 10:48:31 UTC
I fixed this in current stable, hal-0.5.7-r3.ebuild and ~arch hal-0.5.7.1-r1.ebuild, thank you!