Bug 129721 – workrave does not compile with gcc4

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Marcin Deranek 2006-04-12 11:36:27 UTC]

workrave 1.8.2 does not compile with gcc 4.1 on amd64. Here is the patch to fix the problem (haven't tried other gcc versions than 4.1):

--- frontend/gtkmm/src/GtkUtil.hh.orig  2005-09-23 21:22:33.000000000 +0200
+++ frontend/gtkmm/src/GtkUtil.hh       2006-04-12 20:27:26.036144552 +0200
@@ -56,11 +56,11 @@
   create_label(std::string text, bool bold);

   static Gtk::Widget *
-  GtkUtil::create_label_with_tooltip(std::string text,
+  create_label_with_tooltip(std::string text,
                                      std::string tooltip);

   static EventImage *
-  GtkUtil::create_image_with_tooltip(std::string file,
+  create_image_with_tooltip(std::string file,
                                      std::string tooltip);

   static Gtk::Widget *
@@ -84,7 +84,7 @@
   static void set_wmclass(Gtk::Window &window, std::string class_postfix);
   static void center_window(Gtk::Window &window, HeadInfo &head);

-  static bool GtkUtil::has_button_images();
+  static bool has_button_images();
 };

 #endif // GTKMMGUI_HH

[Comment 1 Mark Loeser (RETIRED) 2006-04-13 11:56:46 UTC]

Patch looks fine.  In the future please attach it rather than sticking it inline.    Has this been sent upstream already?

[Comment 2 Leonardo Boshell (RETIRED) 2006-04-13 12:09:36 UTC]

It seems to be applied in CVS already:
http://cvs.sourceforge.net/viewcvs.py/workrave/workrave/frontend/gtkmm/src/GtkUtil.hh?r1=1.6&r2=1.7

Mark, could you please commit this?

[Comment 3 Mark Loeser (RETIRED) 2006-04-13 14:16:46 UTC]

Fixed, thanks Marcin