Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 129719 - sarg 2.1 uses old sort command options
Summary: sarg 2.1 uses old sort command options
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Highest normal (vote)
Assignee: Peter Volkov (RETIRED)
URL: http://sarg.sf.net
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-12 11:24 UTC by Jeremy Heslop
Modified: 2006-04-14 00:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sarg-2.1-index-sort.patch (sarg-2.1-index-sort.patch,757 bytes, patch)
2006-04-12 11:27 UTC, Jeremy Heslop
Details | Diff
sarg-2.1.ebuild (sarg-2.1.ebuild,2.03 KB, text/plain; charset=us-ascii)
2006-04-12 11:36 UTC, Jeremy Heslop
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Heslop 2006-04-12 11:24:17 UTC
When generating sarg reports, it will fail with

sort: open failed: +6.5nr: No such file or directory

Upon inspection of the code, the code that ran a sort on the index in sarg (index.c) was using the old command line options for sort (ie +6.5nr) instead of the new POSIX way of doing things (ie -k 7,5nr). See info sort for more info on differences between new and old.

I modified the code and tested a ptach which seems to work. If I can get others to test and possibly get this into portage that wouldl be great.

Portage 2.1_pre7-r4 (default-linux/amd64/2005.1, gcc-3.4.6, glibc-2.4-r1, 2.6.13-ck5 x86_64)
=================================================================
System uname: 2.6.13-ck5 x86_64 AMD Opteron(tm) Processor 246
Gentoo Base System version 1.12.0_pre17
distcc 2.18.3 x86_64-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
ccache version 2.3 [enabled]
dev-lang/python:     2.3.5, 2.4.2-r1
sys-apps/sandbox:    1.2.17
sys-devel/autoconf:  2.13, 2.59-r7
sys-devel/automake:  1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2
sys-devel/binutils:  2.16.1-r2
sys-devel/libtool:   1.5.22
virtual/os-headers:  2.6.11-r3
ACCEPT_KEYWORDS="amd64 ~amd64"
AUTOCLEAN="yes"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=k8 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/eselect/compiler /etc/gconf /etc/revdep-rebuild /etc/terminfo /etc/env.d"
CXXFLAGS="-march=k8 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoconfig ccache distlocks metadata-transfer sandbox sfperms strict"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/linux/distributions/gentoo/ http://www.gtlib.gatech.edu/pub/gentoo http://gentoo.mirrors.pair.com/ "
MAKEOPTS="-j7"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="amd64 acl apache2 avi bash-completion berkdb bitmap-fonts ck-server cli cracklib crypt cups dbx dynagraph eds emboss encode foomaticdb fortran gd gif glitz gpm graphviz gstreamer imap imlib ipv6 isdnlog jpeg ldap libclamav lzw lzw-tiff mp3 mpeg mysql nagios-dns nagios-ntp nagios-ping nagios-ssh ncurses nls nptl nptlonly oav pam pcre pdflib perl png pppd prelude python quicktime quotas readline samba sdl session snmp spell ssl tcpd tiff truetype-fonts type1-fonts usb xml xpm zlib elibc_glibc kernel_linux userland_GNU"
Unset:  ASFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, LINGUAS
Comment 1 Jeremy Heslop 2006-04-12 11:27:10 UTC
Created attachment 84515 [details, diff]
sarg-2.1-index-sort.patch

Patch to update old sort code.
Comment 2 Jeremy Heslop 2006-04-12 11:36:26 UTC
Created attachment 84516 [details]
sarg-2.1.ebuild

Ebuild that applies above patch. Only added:

epatch ${FILESDIR}/sarg-2.1-index-sort.patch

after other patches.
Comment 3 Peter Volkov (RETIRED) gentoo-dev 2006-04-14 00:12:34 UTC
Thank you for report Jeremy. Good job. :)

Bug is re-reported upstream. Patch is in cvs (sarg-2.1-r1.ebuild). In a month, I'll request to mark this version of sarg stable.