Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 129360 - sbcl-0.9.11 added ppc-macos support
Summary: sbcl-0.9.11 added ppc-macos support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Mac OSX (show other bugs)
Hardware: PPC OS X
: High enhancement
Assignee: Common Lisp Bugs
URL: http://code.sbbod.net/portage-overlay...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-09 09:13 UTC by Nick Dimiduk (RETIRED)
Modified: 2006-04-25 15:40 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ppc-macos patch (ppc-macos.diff,2.20 KB, patch)
2006-04-09 09:13 UTC, Nick Dimiduk (RETIRED)
Details | Diff
disabled sb-test as original (ppc-macos.patch,1.87 KB, patch)
2006-04-14 10:41 UTC, Nick Dimiduk (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Dimiduk (RETIRED) gentoo-dev 2006-04-09 09:13:00 UTC
Nothing significant needed to be done because there is now upstream support.  However, due to issues related to `use ppc` evaluating to true on this arch and related changes to the ebuild, it should be tested on a ppc-linux system.  Attached is a patch to add ppc-macos support.  The ebuild is also available via http in my darcs overlay at the indicated URI.
Comment 1 Nick Dimiduk (RETIRED) gentoo-dev 2006-04-09 09:13:50 UTC
Created attachment 84288 [details, diff]
ppc-macos patch

As above.
Comment 2 Wormo (RETIRED) gentoo-dev 2006-04-11 21:39:28 UTC
Seems ok to me. Successfully built with the patch, and used it to compile maxima which also seems fine.
Comment 3 Matthew Kennedy (RETIRED) gentoo-dev 2006-04-11 23:33:51 UTC
wormo, do you mean to say that it worked on ppc linux or ppc-macos?

Nick, if it is found to work fine on both architectures, you should commit the patch to CVS.  The only question I have about your patch is the last section:

@@ -91,7 +104,7 @@
 #	use x86 \
 #		&& echo '(enable :sb-futex)' \
 #		>>${S}/customize-target-features.lisp
-	echo '(disable :sb-test)' >>${S}/customize-target-features.lisp
+#	echo '(disable :sb-test)' >>${S}/customize-target-features.lisp
 	! use unicode \
 		&& echo '(disable :sb-unicode)' \
 		>>${S}/customize-target-features.lisp

That would affect all archs.  Is there any reason to exclude :sb-test from customize-target-features? 
Comment 4 Wormo (RETIRED) gentoo-dev 2006-04-13 11:04:24 UTC
Worked on ppc linux
Comment 5 Nick Dimiduk (RETIRED) gentoo-dev 2006-04-14 10:19:15 UTC
mkennedy:

That line will be uncommented for submission.  It's not necessary.  Why is sb-test disabled by default?  Is it extra runtime type-checking or something?  I enabled the test hoping for extra output while testing sbcl on ppc-macos.
Comment 6 Nick Dimiduk (RETIRED) gentoo-dev 2006-04-14 10:41:46 UTC
Created attachment 84658 [details, diff]
disabled sb-test as original

Re-disabled sb-test.
Comment 7 Matthew Kennedy (RETIRED) gentoo-dev 2006-04-14 12:47:06 UTC
In the SBCL archive root directory base-target-features.lisp-expr:

 ;; Do regression and other tests when building the system. You might
 ;; or might not want this if you're not a developer, depending on how
 ;; paranoid you are. You probably do want it if you are a developer.
 ;; This test does not affect the target system (in much the same way
 ;; as :sb-after-xc-core, below).
 :sb-test

I can't remember what effect it had exactly, but disabling it for users is a good idea.  I vaguely recall it avoids loading up *-test.asd system definitions and that was a speedup.

I'll apply your latest patch when I get home.
Comment 8 Matthew Kennedy (RETIRED) gentoo-dev 2006-04-21 09:32:18 UTC
Nick, one more question about the patch:

    if use ppc-macos && use ldb; then
        true
    elif use ppc && use ldb; then
        sbcl_einfo <<'EOF'                                                                
Building SBCL on PPC with LDB support is not a supported configuration                    
in Gentoo. Please refer to Bug #121830 for more information.                              
EOF                                                                                       
        die
    fi

I'm not sure what the intention there is.  Does ldb really work on ppc-macos but not on non-macos ppc?
Comment 9 Matthew Kennedy (RETIRED) gentoo-dev 2006-04-24 12:38:20 UTC
I dont think it does, so I adjusted that stanza slightly and committed to portage.
Comment 10 Nick Dimiduk (RETIRED) gentoo-dev 2006-04-25 15:40:33 UTC
Sorry for the delay; I'm in the middle of moving.

I tried building sbcl with the ldb use flag enabled and encountered no compilation errors as described in the associated bug mentioned in the ebuild (#121830).  Hence, I left it as an available option in the patch.