Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 12890 - GRP grp-install.sh scripts adds entry to "world" even if it fails
Summary: GRP grp-install.sh scripts adds entry to "world" even if it fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Release Media
Classification: Unclassified
Component: Everything (show other bugs)
Hardware: All All
: High critical (vote)
Assignee: Mark Guertin
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-29 03:50 UTC by Jared H. Hudson (RETIRED)
Modified: 2005-03-25 11:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared H. Hudson (RETIRED) gentoo-dev 2002-12-29 03:50:50 UTC
If you run grp-install.sh gnome-list.txt mozilla-list.txt
openoffice-bin-list.txt for example and it fails during the gnome-list install,
gnome, mozilla and openoffice-bin still get added to /var/cache/edb/world
Comment 1 Mark Guertin 2003-01-01 17:09:05 UTC
This is related to other things, I think that for GRP we may have to work in  
the ability for 'blind' package installs if possible.  
  
The way I run the script is also with --nodeps option, maybe we need to make  
-K (--usepkgonly) smarter in that it doesn't try to refernce ebuilds when 
installing like this?  This may solve a few other problems that have been 
reported as well on missing builds 
Comment 2 Daniel Robbins (RETIRED) gentoo-dev 2003-01-03 22:47:58 UTC
Yes, --usepkgonly should ignore the Portage tree. Not sure on the existing
behavior of --usepkgonly... carpaski, can you clarify?
Comment 3 Jared H. Hudson (RETIRED) gentoo-dev 2003-01-06 05:53:50 UTC
The problem is not portage. I should have been more clear on this.

The problem is that the grp-install.sh script does not check if the install was
successfull before it adds its entry to "world". This is done in:

echo ">>> Updating world"
WORLDLIST=`echo $LIST | sed "s:-list.txt::g"`

I suggest emerge being "for loop"ed for each *.txt file listed on the command
line and a function being called that adds the entry to "world" if the emerge
exits cleanly.
Comment 4 Mark Guertin 2003-01-06 09:56:48 UTC
This is in fact related to a portage problem still though.  emerge does not
return proper codes on failures (esp. with pkg installs) and therefore this
cannot be implimented until portage can properly return a failed result.

The script doesn't currently check for this as it is pointless right now and
emerge has in fact returned false failures in the past (which is why i don't
currently check this).  It originally had an || exit 1 after the emerge command,
which would occasionally drop out from an error which didn't happen and stop
your install dead.
Comment 5 Mark Guertin 2003-01-06 09:59:23 UTC
also not sure that doing a for loop for pacakge sets will work as expected.  I
spent a lot of time trying to get this to work as smoothly as possible but
portage is sadly not very well equipped at all for binary based installations as
of yet.
Comment 6 Mark Guertin 2003-01-13 10:19:49 UTC
ok, this script will no longer be applicable, so going to close this bug (new
method will use emerge --pkgonly according to drobbins)
Comment 7 Chris Gianelloni (RETIRED) gentoo-dev 2005-03-25 11:24:39 UTC
Moving these so we can remove the "Install CD" component from "Gentoo Linux".

I apologize to everyone for this spam, but according to the bugzilla developers,
this is the only reasonable way to do this.