Bug 128812 – ogmrip-0.9.0-r1 mplayercvs.patch regression and failing against libdvdread-0.9.5-r1

• Status: RESOLVED WONTFIX
• Product: Gentoo Linux

[Description Gergan Penkov 2006-04-04 12:52:01 UTC]

Well in fact these are two bugs, but I'll report them as one, as the patches are trivial.
The regression in the ogmrip-0.9.0-mplayercvs.patch was probably a typo, but it causes some of the configure-tests to fail, because of redefenition of MPLAYER_PRE
The second one is also trivial - including dvdread/ifo_types.h (as of libdvdread-0.9.5) now wants <inttypes.h> or <stdint.h> to be included in advance.
the patches follow...

[Comment 1 Gergan Penkov 2006-04-04 12:54:31 UTC]

Created attachment 83910 [details, diff]
ogmrip-0.9.0-mplayercvs.patch

this changes only one line in the original patch from 
+  AC_DEFINE_UNQUOTED(MPLAYER_PRE, 1, [Mplayer pre version number])
+  AC_DEFINE_UNQUOTED(MPLAYER_PRE, 7, [Mplayer pre version number])
to 
+  AC_DEFINE_UNQUOTED(MPLAYER_MAJOR, 1, [Mplayer major version number])
+  AC_DEFINE_UNQUOTED(MPLAYER_PRE, 7, [Mplayer pre version number])

[Comment 2 Gergan Penkov 2006-04-04 12:55:58 UTC]

Created attachment 83911 [details, diff]
ogmrip-0.9.0-stdint.patch

allows compilation against the new libdvdread

[Comment 3 Analyzer 2006-04-08 22:49:45 UTC]

waiting for including those patches into official repository, because without them omg dont building:(

[Comment 4 Dice Random 2006-04-16 14:53:49 UTC]

These patches fixed my build problems with 0.9.0-r1, thanks a lot.

[Comment 5 Mark Wagner 2006-05-02 10:26:18 UTC]

These patches fixed my build problems with 0.9.0-r1 as well.

[Comment 6 Alexis Ballier 2006-05-11 04:34:24 UTC]

Whoops, sorry for the bad patch I had sent for mplayer cvs.


Anyway as one can see on the Changelog file of the svn repository [1], the support for mplayer-cvs has been added (and probably in a much proper way than the one I proposed in the patch). livdvdread 0.9.5 problem has also been corrected.

Considering this, perhaps it would be a good idea to replace ogmrip 0.90 by a svn snapshot version, wouldn't it ? 
Or maybe wait until a new release ?


[1]http://svn.sourceforge.net/viewcvs.cgi/ogmrip/trunk/ogmrip/ChangeLog?view=markup&pathrev=670)

[Comment 7 Luis Medinas (RETIRED) 2006-07-07 16:44:29 UTC]

Beandog see the metadata this package belongs to media-optical but if media-video wants to take it we can trade ;).

[Comment 8 Luis Medinas (RETIRED) 2006-07-07 16:52:06 UTC]

sorry i missunderstood this package belongs to media-video they will take care of it better than us.

[Comment 9 Olivier Rolland 2006-08-17 13:10:40 UTC]

Can you please apply the mplayercvs patch and mark the bug as FIXED ? The patch in portage is broken for too long.

Thanks,

Olivier

[Comment 10 Steve Dibb (RETIRED) 2006-09-06 11:50:24 UTC]

package.masked, pending removal.  Please try newer version(s) of ogmrip, and open new bugs if necessary.